Favorites not loading.
Yoposoc opened this issue · 27 comments
Oh yeah I actually started reworking all of this a while back. If you could export your favs so I can use them as test data that would help a lot.
oh bless.
not sure how to export favorites but I could export settings.
https://a.uguu.se/Qy6GJaDSuCbL_unl_fav.json
any update to this?
Heyo... I'm guessing you won't fix?
So I just checked that json file and discovered there's only a couple entries under my "custom" favorite lists. One entry in "Backlog #1" and two in "Things to translate".
Where did all of them go?
I even tried to see in the code how it fetches those numbers that I see when I navigate to my favorites page on exh. I couldn't figure it out.
At the very least is there a way to export them somehow so I can have a list of the galleries that were in a custom favorites list?
oh man sorry about the extreme delay. the past few months were pretty stressful.
So ehm hmm what do you see in the console (ctrl + shift + i). it should just print the raw saved variable to console, so either it's there or it's gone
Ok, I turned off all other extensions and turned on unlimited_favs. I then navigated to one of the custom favlists I had. This is what it looks like:
Here is a gif that shows this behavior. As you can see it first "goes" to my last non-custom list and then a few seconds later (it's usually within 1 second) loads up a bugged view:
This is the console output:
The first 3 object logs (with an array of 3 elements) are shown each time it needs to load the page. Clicking the array shows properly the three favlists I'm supposed to have.
The array of 25 came up once I clicked on Backlog #1
AND it bugged out to show nothing. Only after that did that console entry show up.
Looking at one of the elements in that array, I can confirm it is a record of a gallery that I put into backlog #1
.
however, not sure why it's only 25 elements.
here's another showing of the bugged behavior https://z.zz.ht/6dvvC.gif
hmm are you using tampermonkey or greasemonkey?
I think tampermonkey has an option to complete backup your extensions with settings and all.
trying hard to get a working version out, but I'd rather first make sure you don't lose access to your current lists
oh I guess greasemonkey doesn't work with the script at all?
well anyways in the dashboard under utilities you have the option to zip export and in the zip there should be a file called unlimited favs.storage.json
which should be the just raw json
hmm are you using tampermonkey or greasemonkey?
I'm using violentmonkey actually, which I believe is similar to greasemonkey.
Now that you mentioned it, I see a "values" tab in violentmonkey which has a favsJson
that looks right! :D
https://p.teknik.io/Raw/l8p70
Okay I still need to do this for the other display modes and I want to make the search work this time, but this looks pretty good imo
tags are all misc only cos I didn't use to save the category data back then, but I do now and I'll add an update function soon enough. when you add new galleries it looks fine:
also non standard thumbnail sizes look shitty for now but w/e
also non standard thumbnail sizes look shitty for now but w/e
yeah I think that's much lower priority. Awesome work on this, thanks a lot.
What do you mean by tag highlighting? I'm using a different userscript for that, maybe you just need to ensure no conflicts exist? I'll try it out right now.
well uh you didn't push your updated script anywhere.... so....
well uh you didn't push your updated script anywhere.... so....
the standard tag highlighting from the website, no userscript. well also not really important.
Anyways okay I'll push an update to the other branch, so you can install it as a separate script, but do expect bugs.
install: https://github.com/ZerataX/unlimted_favorites/raw/ZerataX-cleanup/unlfavs.user.js
your favJson
is currently in a string and not json format, so to import it you need to remove the first "
and the last "
and replace every instance of \"
with "
also got a search working that does everything except for the $
sign
oh also when adding favorites that currently only works by double clicking the item, not with the apply button.
Hmm just noticed that the search is kinda dumb.
if you currently search for english p:"kantai collection"
you get the union instead of the intersection.
also currently i only use the shortcodes for namespaces e.g. f
instead of female
everything else should work as expected, if not please report it
cool, I'm testing it out and I'll create issues as needed. Found some already.
had some time today and now also added thumbnail mode in 8bd75ad
I think search now really works well, just needs a proper button and enter function I guess.
nice!
are you going to merge the branch so that whoever has the script will autoupdate?
are you going to merge the branch so that whoever has the script will autoupdate?
Yeah but I first want to fix a few more things.
I just finished the other favorite page display modes.
Now I just want to:
- introduce a warning for a new version so that you can backup before updating
- Make sure updating galleries (e.g. changing notes) doesn't update the favorited timestamp
- #7
- and a proper search button
which is all really quickly done, just need to find some time
gonna guess no progress on this?
@Yoposoc fixed the last issues and made it the default version.
so hopefully it updates for everyone automatically, but I'm not sure.
it does import old saves and fixes them, tho I do recommend pressing the update all
button once in the settings page (that gets the latest tags for every gallery and sorts them properly).
it will take a few seconds so wait until a finished dialogue appears.
Got it. Will report back if I have issues again.
doesn't work again anymore. all other extensions are disabled. Been a while since I checked this so not sure when it started breaking.