zero-to-mastery/ZTM-Quest

Bug: Joke Teller NPC Spawn Point Blocks Character Interaction in `map_start`

Closed this issue · 2 comments

In the current implementation of the map_start scene, the Joke Teller NPC is positioned in a way that obstructs the player character from reaching the computer. As shown in the attached video, due to the NPC's spawn location, it blocks the path to the computer, making it impossible for players to interact with it. I realized this while working on #36 that was assigned to me.

Screen.Recording.2024-10-02.at.10.46.36.PM.mov

The NPC's spawn point is currently set at { x: 90, y: 250 }, which places the NPC directly in the way of the computer's interaction point.

Proposed Solution:

To resolve this, the NPC's spawn coordinates should be adjusted to a different location where it won’t interfere with the player's movement. An updated spawn position away from the interaction path would fix this issue while retaining the NPC’s presence in the scene.

I’m happy to implement the fix by modifying the spawn coordinates. Please let me know your preferred position for the NPC, or I can suggest a new location based on the scene layout.

const spawnPoint = spawnpoints.jokeTeller || { x: 90, y: 250 };

@r4pt0s, if you want me to fix this issue, I will send in a pull request with the updated coordinates.

@r4pt0s, I unintentionally ended up fixing this in #63. Is that okay or do you want me to revert back to the older coordinates.

Before

const spawnPoint = spawnpoints.jokeTeller || { x: 90, y: 250 };

After

const spawnPoint = spawnpoints.jokeTeller || { x: 90, y: 280 };

@AryanK1511 sure. I already merged #63