zerodha/dotnetkiteconnect

GetHistoricalData failing due to integer overflow

sanchitabrol opened this issue · 2 comments

sanchitabrol commented

While fetching Daily data for NSE:GLTINFRA (3518721), this conversion is failing since Volume is 6161122183 on 2020-07-13 which is greater that UInt32.MaxValue. You probably need to change the contract to accommodate larger values.

dotnetkiteconnect/KiteConnect/Structures.cs

Line 69 in eb6304b

Volume = Convert.ToUInt32(data[5]);

ajinasokan commented

Yes. This should be UInt64. I will patch and release as 4.0.0-pre.