zerotier/terraform-provider-zerotier

Merging features with bltavares/terraform-provider-zerotier

bltavares opened this issue · 4 comments

bltavares commented

Hello there folks,

I'm really happy to see updates on zerotier. I've been using and maintaining my own version of the terraform provider for about 2-3 years already and I would like to merge some features so I can deprecate my version.

Here are the list of missing features:

Those were missing features required for me to migrate my current network definition to Terraform, and better integrate with other providers. Having separate computed properties on network and member for 6plane and RFC4193 attributes allows easier integration with a DNS provider or with file outputs for scripting.

I won't have time the following weeks to make this change as PRs, but all suggested commits should be easily ported to new versions but I can take a look at it on the next month.

someara commented

Hi Bruno!

Thanks for this.
I'll get these to you soon!

-s

  • 👍1
  • 🎉1
erikh commented

Hi, I wrote most of the code here. I'm fine with these suggestions myself.

I'm a little hesitant on computed addresses as I was playing with some stuff around CIDR computation (if it's not still in tree, it's in the log) for these situations that I gutted because it wasn't going so hot. :) Mostly a lack of understanding on my part about the state lifecycles in terraform, would mostly just like to make sure a new implementation doesn't re-introduce that. The CIDR code was fine however and you may wish to use it, it's fairly efficient.

anyways I'll try to dip a toe in and help. I am working on a few other projects that require a lot of attention so I may not be very fast. Feel free to reach me @ my github profile's email if you'd prefer to coordinate off github.

bltavares commented

Hey @erikh, I'm glad the suggestions are well received. No worries on taking a look at this, as neither do I have time to work on it also on the short term.

I mostly wanted to share it early so the differences are mapped and we can work together to unify the features.

Thanks for mentioning the issues you've found with computed properties. Would you be able to share more details of what happened? I've been using it for a while already, and as long as I used the schema.TypeSet I didn't have any issues with Terraform.

erikh commented

I'm trying to remember; it was almost certainly something I was doing wrong. I'll make a note to bisect it later; sean and I hit it during release prep and there was a version with it it in there.