zertrin/duplicity-backup.sh

VERSION file issues

rebelga opened this issue · 1 comments

rebelga commented
  1. The new VERSION file makes an external dependency for the script. Previously it worked fine standalone.
  2. "VERSION" is a very generic filename, may potentially clash with other software, and is difficult to relate to this script when loaded in directories with other files.

Suggestion: put the version number in the script itself.

zertrin commented

You were right. I guess what happened is that I first created the VERSION file, and then much later implemented a way to output the version from the script.

I've followed your suggestion in v1.4.2.

Thanks for reporting!