remove NOT NULL for client_secret

[goalain]

In
oauth_clients -> client_secret character varying(80) NOT NULL,

And then in PDO:
public function isPublicClient($client_id) { $stmt = $this->db->prepare(sprintf('SELECT * from %s where client_id = :client_id', $this->config['client_table'])); $stmt->execute(compact('client_id')); if (!$result = $stmt->fetch(\PDO::FETCH_ASSOC)) { return false; } return empty($result['client_secret']); }

How can $result['client_secret'] be empty?
IMHO the "NOT NULL" is wrong as it is needed I.E. for 'allow_implicit' => true example.

[weierophinney]

This repository has been closed and moved to laminas-api-tools/api-tools-oauth2; a new issue has been opened at laminas-api-tools/api-tools-oauth2#9.