Any plans to improve the code quality of the package?
Closed this issue · 2 comments
michael-rubel commented
Hello, @zgabievi!
The package looks nice, but a bit outdated.
I faced some problems using it in production, had to override the main class.
What you'll say if I'll send the PR of a more modern typed version of the package, and probably with the option to point out the model to use? It will require PHP 8 and probably Laravel 8.x.
zgabievi commented
Sure @michael-rubel. Feel free to open pr. I’m planning to rewrite this package to more structured code, just couldn’t find free time to work on that for now.
michael-rubel commented
@zgabievi A bit too late, but thanks for the answer!
Had to handle the case myself and created: https://github.com/michael-rubel/laravel-couponables