zhaofengli/kubevirt-actions-runner

Add support for RunnerScaleSet

Closed this issue · 1 comments

jalvarezit commented

This project uses old RunnerDeployment which are deprecated acording to the docs:

With the introduction of actions/actions-runner-controller#2775, the existing autoscaling modes are now legacy. The legacy modes have certain use cases and will continue to be maintained by the community only.

Testing it out with the new RunnerScaleSet the project does not seem to work.

Steps to reproduce:

  • Setup github action runner controller following the quickstart

  • Create this VirtualMachine object.

  • Setup RBAC as in the README

  • Add the following to the RUnnerScaleSet template spec:

      serviceAccountName: kubevirt-actions-runner
    image: ghcr.io/zhaofengli/kubevirt-actions-runner:latest
    repository: org/repo

    # To prevent ARC from starting a separate container
    dockerdWithinRunnerContainer: true
zhaofengli commented

Thanks for the report! This is implemented in #3.

  • ❤️1