zhbjsh/homeassistant-ssh

Allow returned responses to be optional in actions configuration

Closed this issue · 3 comments

I'm working on creating a universal media player entity, which requires me to run a SSH command on a Linux host to set the volume since MPD isn't handling that properly. However, when doing this through an execute_command action from this integration, I get an error:

Screenshot 2024-11-11 at 6 00 03 PM

This appears to be coming from HA here because the actions/services provided here are set to require responses to be returned. It seems like it would be possible to register actions as SupportsResponse.OPTIONAL, and expose a new parameter in the action data for execute_command for whether or not a response should be returned (default true for backwards compatibility).

I started looking into implementing this in a PR here but seems like it might also require updates to ssh-terminal-manager

Thanks for the feedback! I will try to make the response optional when I have time!

I made all service responses optional in version 1.0.1, please take a look if everything works!

It works perfectly! Thank you for working on this