zhen8838/Circle-Loss

Why useing same y_pred for sn and sp?

lbf4616 opened this issue · 1 comments

According to the paper and other implementations, sn and sp should be different, but you used y_pred for both of them, could you please explain why?

Circle-Loss/circle_loss.py

Lines 128 to 129 in fc4d73a

y_pred = (y_true * (alpha_p * (y_pred - self.Delta_p)) +
(1 - y_true) * (alpha_n * (y_pred - self.Delta_n))) * self.gamma

by multiply y_true and (1 - y_true) for sp and sn, thats awsome!