Nautical Miles
Closed this issue · 5 comments
steveneal commented
Hi.
I've added a NAUTICAL type locally, that extends the IMPERIAL and METRIC types, so that nautical miles can be used measurement units.
I need this to be able to use your tool. Can I create a branch to push this to for you to pull? Or is it something you could add quickly. It's just a few lines of code.
Thanks, Steve.
zhenyanghua commented
Excellent! You can create a pull-request and after testing it I will merge your pull-request to the master branch.
steveneal commented
I can't create a branch to push my changes to in order to set up a pull
request.
Can you set me up as a collaborator?
…On 1 May 2018 at 17:27, Zhenyang Hua ***@***.***> wrote:
Excellent! You can create a pull-request and after testing it I will merge
your pull-request to the master branch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAU7LfLagry37SremFaL18oX5QEv8hWHks5tuH7GgaJpZM4TuELs>
.
zhenyanghua commented
you should follow the recommended GitHub collaboration flow for the pull request. Fork from mine and make the changes on yours and submit the PR to merge into mine. and I will take it from there. Thanks!
steveneal commented
Done. Apologies for the confusion :)
zhenyanghua commented
Merged and resolved in PR #40