zhuker/lamejs

Can't Resolve Module - lamejs is broken for npm usage

djalmaaraujo opened this issue · 11 comments

djalmaaraujo commented 
ERROR in ./~/use-strict/index.js
Module not found: Error: Can't resolve 'module' in '/Users/cooper/dev/closeio/closeio/closeio/static/node_modules/use-strict'
 @ ./~/use-strict/index.js 1:13-30
 @ ./~/lamejs/src/js/lametest.js
 @ ./js/voicemail-recorder/encoder.js
 @ ./js/voicemail-recorder/mic-recorder.js
 @ ./js/views/settings/voicemail_recorder.js
 @ ./js/test/tests/settings/voicemail_recorder.js
 @ ./js/test/tests.js

If you comment the first line on lametest.js, everythin works as expected:

// require('use-strict');

@zhuker
I am using the npm-package lamejs. I am not sure the reason you are using this module "use-strict", but it fixes when you comment this line. If you think this module is not useful anymore, I can remove and open a PR.

Jandou6 commented

I have the same problem, Cannot resolve module 'module'......??

deanslamajr commented

c4638f8 closes this issue also

@zhuker @geeee will c4638f8 be deployed to npm?

  • 👍1
deanslamajr commented

@djalmaaraujo @Jandou6
due to this repo's owners not deploying the latest branch to npm, I've forked and deployed a working version => https://www.npmjs.com/package/iso-lamejs

  • 👍4
buzinas commented

@geeee @zhuker can you please publish master on npm under ^1.2.0?

zhuker commented

@buzinas published let me know if it works

zhuker commented

published 1.2.0 to npm

djalmaaraujo commented

@deanslamajr check it out.l

buzinas commented

Thanks @zhuker, I'll test it.

deanslamajr commented

@djalmaaraujo yep, this works!!
Thanks @zhuker

djalmaaraujo commented

Thanks @zhuker, this is why we wanted to use your library: https://github.com/closeio/mic-recorder-to-mp3

  • 👍1