zikula/core

Error when removing assets_version parameter

Closed this issue · 8 comments

Guite commented
Q A
Zikula Version 3.1.0-dev
PHP Version 7.4.3

Expected Behavior

Site loads when removing assets_version: ~ #e.g. 'v1' from here

Current Behavior

I get this exception:

You have requested a non-existent parameter "assets_version".

Screenshot_20200923_073802

Insights

I did not find any occurance of assets_version in src.

So apparently this parameter is not set by any configuration at the moment. Should it be part of the Theme module? Or should we keep it in /config/services.yaml?

Context

This occured after I updated my 3.0.4-dev site to 3.1.0-dev. So very probably I am overseeing something, similarly to
7f43a4c#commitcomment-42646759

craigh commented

You have fully removed the old services_custom.yaml file? It should be gone. Also the the old config/generated dir - remove it.

Guite commented

I didn't remove config/dynamic/ yet. After I did that, I now receive:
You have requested a non-existent parameter "zikula.session.name".

Also, You have requested a non-existent parameter "assets_version". still occurs if I disable assets_version: ~ #e.g. 'v1'.

craigh commented

none of this makes sense to me. to be honest, I did not work with upgrades much when I did the initial work and I acknowledge that it was incomplete, but at the code-level, none of these parameters should be required. Sadly, I don't have time atm to work on it.

Guite commented

no hurry, we can talk about it in Slack in a few days... maybe I find something in the meanwhile

craigh commented

my new install of 3.1.0 was working fine after full removal of everything.

craigh commented

please show the contents of your config/packages/framework.yaml

Guite commented

Good suggestion 👍

Replaced whole config/ folder by master version and things worked again!
Thanks.