zikula/core

Do we still need `/config` to be writable?

craigh opened this issue · 2 comments

With changes to 3.1.0 now no longer requiring writing to config/services_custom.yaml (is removed) does the system require write access to /config at all? If no, the we can remove these checks from src/Zikula/CoreInstallerBundle/Util/RequirementChecker.php and src/Zikula/CoreInstallerBundle/Util/ZikulaRequirements.php

Additionally, \Zikula\Bundle\CoreInstallerBundle\Util\RequirementChecker::loadParametersFromFile is still checking for config/services_custom.yaml and this can probably be removed.

  • In the end, the "only" two parameters that appear to be checked or used are the 'datadir' and 'kernel.project_dir' so perhaps all the parameters except those can be ignored.

Just thinking again that possibly when using the UI to set custom values (like session name for example) that the web server will write/create a custom config file, so perhaps the dir is required to be writable.

just tested and indeed this is true, so write access must be kept.

other issues must be addressed above though.