zio/interop-reactive-streams

Please publish against ZIO 1.0.0-RC12-1

cchepelov opened this issue · 4 comments

cchepelov commented

Please publish zio/interop-reactive-streams against ZIO 1.0.0-RC12-1

According to MIMA, multiple ABI changes happened in ZStream between zio-stream 1.0.0-RC11-1 and 1.0.0-RC12-1, which makes a system depending on both zio % 1.0.0-RC12-1 and interop-reactive-streams % 1.0.3.0-RC1 unable to load due to IncompatibleClassChangeError as expected by interop's QueueSubscriber$ and QueueAdapter$

Attempting to bump the dependency from interop-reactive-streams to zio-stream % 1.0.0-RC12-1 cause a compile error due to the disappearance of ZStream#Fold, and I'm afraid I'm not able to come up quickly enough with the proper patch.

Thanks in avance

neko-kai commented

Eh, I tried to but failed at porting QueueSubscriber.stream over to Pull... Could anyone better at ZStream take this when you have the time? @iravid @zio/core

runtologist commented

I'm working on it. The main changes are in. I need to rewrite a bunch of tests. This will introduce API breaking changes in interop-reactivestreams to make things more resource-safe. I can push a WIP, to collect early feedback. I hope I'll get the change completed during the weekend.

iravid commented

Thanks @runtologist! Happy to help if you have any questions on the new encoding

runtologist commented

Thanks @iravid. It would be great if you could take a look at the PR. I've changed the API for sinkToSubscriber in a breaking way, so I could move a lot of state-keeping into resource acquisition.