Skins aren't showing on a server that didn't send the skins to begin with (1.18.2 Fabric)
Hedwig7s opened this issue · 17 comments
Server is viaproxy.raphimc.net (server tested on is /viaproxy 5.161.70.101:25566 b1.2-b1.2.2 betacraft)
It doesn't send skins to the client so I thought this mod would fix that and it didn't
Everyone was still an Alex with and without the mod
Tested with 1.12.2 Forge and it does fix the no skin issue
The mod still respect the information sent from the server. If I remembered correctly, If the server told the client that these players have UUIDs that is not auto-generated offline ones and with profiles pre-filled properties, in default settings, the mod will not try to resolve these 'complete' profiles with their usernames, therefor only default skins.
Also, you should hide that IP address.
The mod still respect the information sent from the server. If I remembered correctly, If the server told the client that these players have UUIDs that is not auto-generated offline ones and with profiles pre-filled properties, in default settings, the mod will not try to resolve these 'complete' profiles with their usernames, therefor only default skins. Also, you should hide that IP address.
First the IP is public knowledge dw (it's a VPS anyway) second what do I change to fix it then?
Is your server custom 3rd party software? If so, try a vanilla one or a pure Forge/Fabric one.
Is your client launcher custom 3rd party software? If so, try vanilla launcher.
Is your server custom 3rd party software? If so, try a vanilla one or a pure Forge/Fabric one. Is your client launcher custom 3rd party software? If so, try vanilla launcher.
Thing is that server is a proxy for old versions so can't just test different software
Could you add a setting to force downloading skins?
The mod still respect the information sent from the server. If I remembered correctly, If the server told the client that these players have UUIDs that is not auto-generated offline ones and with profiles pre-filled properties, in default settings, the mod will not try to resolve these 'complete' profiles with their usernames, therefor only default skins. Also, you should hide that IP address.
Response from the proxy creator:
Its a bit more complicated how I do stuff, I am sending a seperate UUID for the player and the player list entry. The player is spawned with its offline UUID. I am removing that player list entry after the player has been spawned and add another one with a different UUID which is only there for visual purposes and is not linked to the player in any way
Alright so the issue is the player list and player are unlinked
Could they both be done seperately by name?
If the usernames are accurate, they will be resolved by this mod using a rate-limited Mojang API.
But because they are different profiles, the same username will be queried multiple times which might cause the limit be reached.
Nvm, the code I wrote prevent multiple queries on the same username in short period.
The server/proxy needs to send profiles with empty properties to the client so that this mod will try to fill it using Mojang services.
If the usernames are accurate, they will be resolved by this mod using a rate-limited Mojang API. But because they are different profiles, the same username will be queried multiple times which might cause the limit be reached.Nvm, the code I wrote prevent multiple queries on the same username in short period.The server/proxy needs to send profiles with empty properties to the client so that this mod will try to fill it using Mojang services.
Can you add a setting to force it even with profiles
I could, but I still don't know what cause as both Forge version and Fabric version should be identical in functions.
I could, but I still don't know what cause as both Forge version and Fabric version should be identical in functions.
Well for some reason the 1.12.2 one is working fine but not 1.18.2 fabric
Still please just add the ability to force it
Do you need it to be for 1.18.2?
Do you need it to be for 1.18.2?
Yeah 1.18.2 fabric if possible
You can try this: https://github.com/zlainsama/OfflineSkins/releases/tag/1.18.2-v2a-fabric-test
An option called 'forceResolveUsernames' is added, you need to set it to true.
You can try this: https://github.com/zlainsama/OfflineSkins/releases/tag/1.18.2-v2a-fabric-test An option called 'forceResolveUsernames' is added, you need to set it to true.
Nope didn't work
Could it have anything to do with the player list and player entities being seperate (UUID)?
Then the only points it can fall into are these three...
- The properties of the profile is null.
- The username of the profile is blank.
- There is no profiles to begin with, due to compatibilities reasons, recent versions of OfflineSkins switched to hijack PlayerInfo(Forge)/PlayerListEntry(Fabric).
Could you also test it with 1.18.2 Forge? just to make sure.
1.18.2 Forge does the same thing
Then it might really has something to do with the player list and player entities being separate...