zmoazeni/csscss

Incorrectly reporting duplicate declarations when using @font-face

jjenzz opened this issue · 1 comments

When using something similar to the following:

@font-face {
  font-family: 'Museo Sans Rounded';
  src: url('../fonts/museosansrounded-300-mmm.eot');
  src: url('../fonts/museosansrounded-300-mmm.eot?#iefix') format('embedded-opentype'),
       url('../fonts/museosansrounded-300-mmm.woff') format('woff'),
       url('../fonts/museosansrounded-300-mmm.ttf') format('truetype'),
       url('../fonts/museosansrounded-700-mmm.svg#museo') format('svg');
  font-weight: 300;
  font-style: normal;
}

@font-face {
  font-family: 'Museo Sans Rounded';
  src: url('../fonts/museosansrounded-500-mmm.eot');
  src: url('../fonts/museosansrounded-500-mmm.eot?#iefix') format('embedded-opentype'),
       url('../fonts/museosansrounded-500-mmm.woff') format('woff'),
       url('../fonts/museosansrounded-500-mmm.ttf') format('truetype'),
       url('../fonts/museosansrounded-700-mmm.svg#museo') format('svg');
  font-weight: 500;
  font-style: normal;
}

.whatever {
  font-family: 'Museo Sans Rounded';
  font-weight: 300;
}

csscss -n 2 -v /path/to/file.css would report that {@font-face} AND {.whatever} share 2 rules. Yes, they do, but for necessary reasons.

Is this not an issue of just bumping up the minimum number of matches? I'm beginning to think the default -n 3 is still too low.

I'm going to close this, but feel free to re-open if you have a strong argument otherwise.