zombocom/rack-timeout

Ruby 2.2 warnings: instance variables @logger, @runner @cancelled not initialized

dentarg opened this issue · 2 comments

Repro code: https://github.com/dentarg/gists/tree/master/gists/rack-timeout-9fcf (commit)

Ruby 2.2.6

$ ruby -w test.rb
Loaded suite test
Started
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:65: warning: instance variable @runner not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:29: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:33: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:29: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:29: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
./Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:33: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:29: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:29: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:33: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/support/scheduler.rb:33: warning: instance variable @cancelled not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
/Users/dentarg/.gem/ruby/2.2.6/gems/rack-timeout-0.4.2/lib/rack/timeout/logging-observer.rb:31: warning: instance variable @logger not initialized
.

Finished in 1.023162 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
2 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1.95 tests/s, 1.95 assertions/s

Correction, this will not be fixed by #125.

This gem currently doesn't have any tests. Would you be interested in contributing your test case? Or, alternatively, may I have permission to add it to the gem?

@wuputah you have my permission :) (I don’t think I have time to contribute a proper test case right now, sorry)