zombocom/rack-timeout

Reduce verbosity of default logging

wuputah opened this issue · 4 comments

From #60, I agree that most people do not expect to see logging from rack-timeout unless it interrupts a request. I think that today's ERROR would be a more appropriate default rather than using the app's current logging level, which may be DEBUG or INFO by default, depending on the mode it's running in (i.e. production, development).

(n.b. This fails to address the potential difficulties in having a different log level for Rack::Timeout, and the impact this will have that people may be relying on the current default. Implementation may also be an opportunity to address #104.)

Possible alternative, this could be accomplished by re-considering what messages are logged at INFO, with more messaging moving to DEBUG. So it doesn't necessarily mean setting ERROR as the default, but rather trying to be less verbose "by default" regardless of what that default is.

I don't have a strong preference here. #60 is closed. Is there an actionable implementation that you want someone to contribute or is this issue for exploration/opportunity-finding? Last comment here was over a year ago.

I think we should discuss concrete implementations with proposals via a PR. I want to clean up issues. If this is intended to be actively worked on let me know and we can re-open.

If you're intending someone else to do the work and this is more of a "PRs welcome" issue, then I think we make that more clear and spec out the design a bit more in a new issue.

This was a to-do item for consideration that evolved from the discussions in #60.