zonyitoo/context-rs

Release 1.0?

dpc opened this issue · 19 comments

dpc commented

Hi,

Any idea when 1.0 will be released?

I'm currently busy with my exams, but IMO I'd be possible to release it within this week if no other issues pop up.

I think it's appropriate to say that you can start experimenting with the 1.0 branch already if you'd like to, because I'm 90% sure that the only thing that might change is a unit-test due to #27, or some documentation.

dpc commented

miioco master branch have been already ported to contex-rs#1.0 and it works fine in Linux&Windows. As we want to release on crates.io soon, we're blocked on context-rs.

@dpc Wow, so quick! As @lhecker said, we can release 1.0 anytime if no other issues pop up. We have found some fatal issues before in this branch, so I suggest that we could release this branch in the weekend and make sure that everything is work.

From now on, lets hope there are no other users open issues. :)

dpc commented

Have you considered one more 0.x release? In rather small community like Rust, I have noticed that the ode gets reall testing only after a release on crates.io.

dpc commented

You could release 0.x now, and 1.0 in a month, if nothing pops up.

@dpc I haven't made any useful modifications in 0.x . And I think I have already published some versions of 0.x on the crates.io.

dpc commented

I mean: take 1.0 branch and release it as 0.8 or whatever is the latest. After it receives some downloads and testing, release 1.0.

@dpc Sounds fair. @lhecker Do you think it is a good idea?

dpc commented

Also, I think it's possible to release things like 1.0rc1 or 1.0alpha etc.

Well the code base of this is quite small and received extensive testing on 11 different platforms using test-cases, which are much larger in total than the actual code itself. So the probability of errors in the code is IMO very small.

I'd still be nice if someone would test this on a Android phone though, so… I guess we could release a 1.0rc1 version, although I'd personally prefer to release a 1.0.0 instead, because we could release a 1.0.1 etc. later on anyways if issues come up.

Ok, let me switch the 1.0 branch as the master branch.

@lhecker Should I rebase the commits? I think it looks Ok though.

No! We still need to fix the stack alignment unit test for ARM… I'll fix that today in the coming hours and after that we could actually merge and release the code.

Should I rebase the commits?

Do you mean you want to smash the commits into one? Because that would be impossible. Otherwise I'd simply merge the branches (with or without a PR) and push it to master.

We need to set up the documentation page beforehand - could you do this today, @zonyitoo?

@lhecker I think the https://crates.fyi will do the trick.

https://crates.fyi/crates/context/0.2.1/ This is the document.

And I will leave the job about merging to you, you could merge it right after you have done your modifications. :)
And then I will publish it to crates.io immediately.

Cool! I think I'll push only 3 more commits:

  • A fix for the stack alignment unit test
  • Pull the newest assembler code from Boost.Context
  • Add the link to the README.md

And then we should be good to go.

Hey @dpc! 1.0 should be out until tomorrow (if nothing goes wrong). 😊

dpc commented

Wow. You guys are really fast responding. Awesome. I will release mioco this/next week.

@dpc Thanks for your compliments. And @zonyitoo released 1.0.0 just now. 😊

dpc commented

Congratulations to all people involved!