zzarcon/gh-emoji

Better structure for project

rpunkfu opened this issue · 6 comments

rpunkfu commented

We should probably move files to lib, bin directories and in future separate it into some modules, same goes for the tests. What do you think @zzarcon?

ryyppy commented

What would you put into the bin directory? Because usually this is a pretty common directory for global node scripts in npm packages

rpunkfu commented

Usually bin is an entry point for npm and all functionality is imported from lib. It was just a loose idea, I'd love to know your opinion @ryyppy :)

ryyppy commented

So usually for ES6 people tend to use the ./src directory... I would also suggest to split functionality of gh-emoji.js up in multiple files as the code grows, so we maybe wanna move the current source to src/index.js and iterate from there

  • 👍2
rpunkfu commented

Yes, that's what I proposed yesterday to @zzarcon :)

rpunkfu commented

Will open PR with it later :)

rpunkfu commented

Structure is pretty much improved with #23 & #25. There's going to be a new issue about splitting functionality into multiple modules.