0xbitches/sd-webui-lcm

Integrate with existing diffusion pipeline

ljleb opened this issue · 3 comments

ljleb commented

Hi, I notice this extension is in its very early stages. I wanted to leave my two cents in case it could be of any help.

In no particular order:

  • is it possible to implement this extension without relying on the diffusers library? I know it's simpler to use diffusers, but unless it's possible to integrate it well with the existing code, it will not be possible to use existing extensions with LCMs.
  • downloading the base LCM models when booting the webui is not a good idea. If it's really necessary to go through the diffusers library, it would be better UX if a button in the UI tab could trigger the download so that the UI can still be used during download.
  • It would be better if LCMs were added as a type of model you can load using the checkpoint picker dropdown at least, as this would make manual model unloading not necessary anymore

I don't know how easy it is to make any of these changes, except maybe for the download on webui startup. I'm currently looking into the other points a little bit, not sure what I'll find.

0xbitches commented

Thanks for the tips. It's an understatement to say this extension is in very early stages.

  1. This is planned. Ideally we would have the LCMSampler integrated in A1111.
  2. While this is easy to implement, I currently do not have the time to tend to it. If anyone is up to the task, feel free to submit a PR.
  3. Should be implemented alongside 2.
  • 👍3
  • 🚀2
ljleb commented

I'll make a PR for 2.

  • 👍1
ljleb commented

For 3. I need to look into the code a little bit, if I see a good way to do it I'll send a follow up PR if no one has done it yet.

  • 👍2
  • 🚀1