0xrusowsky/2024-01-olympus-on-chain-governance

HTML

Olympus On-Chain Governance contest details

Join Sherlock Discord
Submit findings using the issue page in your private contest repo (label issues as med or high)
Read for more details

Q&A

Q: On what chains are the smart contracts going to be deployed?

Mainnet

Q: Which ERC20 tokens do you expect will interact with the smart contracts?

gOHM

Q: Which ERC721 tokens do you expect will interact with the smart contracts?

None

Q: Do you plan to support ERC1155?

No

Q: Which ERC777 tokens do you expect will interact with the smart contracts?

None

Q: Are there any FEE-ON-TRANSFER tokens interacting with the smart contracts?

No

Q: Are there any REBASING tokens interacting with the smart contracts?

No

Q: Are the admins of the protocols your contracts integrate with (if any) TRUSTED or RESTRICTED?

TRUSTED

Q: Is the admin/owner of the protocol/contracts TRUSTED or RESTRICTED?

TRUSTED

Q: Are there any additional protocol roles? If yes, please explain in detail:

Veto Guardian: TRUSTED admin that can veto proposals in case of emergency

Q: Is the code/contract expected to comply with any EIPs? Are there specific assumptions around adhering to those EIPs that Watsons should be aware of?

No

Q: Please list any known issues/acceptable risks that should not result in a valid finding.

N/A

Q: Please provide links to previous audits (if any).

It is based on GovernorBravo which has the following audit history:

Q: Are there any off-chain mechanisms or off-chain procedures for the protocol (keeper bots, input validation expectations, etc)?

We will have a proposal simulation framework, but it doesn't effect the actual potential use of the governance system

Q: In case of external protocol integrations, are the risks of external contracts pausing or executing an emergency withdrawal acceptable? If not, Watsons will submit issues related to these situations that can harm your protocol's functionality.

No

Q: Do you expect to use any of the following tokens with non-standard behaviour with the smart contracts?

No

Q: Add links to relevant protocol resources

V3 Repo: https://github.com/OlympusDAO/olympus-v3
Docs: https://docs.olympusdao.finance/

Audit scope

bophades @ 3c4098ef9b2870f4ebd912b15466780676ba7db8