3F/MvsSln

Retrieving solution breaks when solution contains a *.deployproj project

Closed this issue · 8 comments

wouterroos commented 
using (var sln = new Sln(solutionPath, SlnItems.All & ~SlnItems.ProjectDependencies))
{
}

Above code breaks when solution contains a *.deployproj project (used for Azure Resource Group deployments).

wouterroos commented

Hi,

I created #15 to fix the issue, the project type guid for .deployproj files is not known within your library. I also added the correct guid for Service Fabric (.sfproj) project since I will be needing that as well for my project.

  • ❤️1
3F commented

breaks when solution contains

By the way, this is not correct behavior! Broken after 2.1. Seems I forgot to process ProjectType.Unknown case:

MvsSln/MvsSln/Core/Guids.cs

Line 68 in 97896c4

return ProjectTypeGuids.Where(p => p.Value == guid)

Also, this is not optimized because of full processing from Where clause -_-

I can fix this later or you.

3F commented

Yes, confirmed. v2.1 works fine when some guids are not presented in our lib.
It's bug of the new 2.2

wouterroos commented

Hi,

Thanks for investigating. I tried reverting to 2.1 to see if that could unblock me for my project, unfortunately I now run into the issue below (that has been fixed in 2.2).

  • FIXED: Fixed possible error when loading all found projects:
    'An equivalent project is already present in the project collection, ...'
wouterroos commented

I updated #15 with a fix for the lookup of unknown project types.

3F commented

Approved. Thanks again!

wouterroos commented

@3F Any ETA on when this will be available on NuGet?

3F commented