Calling rebuild_hyb_matrix in remove_antisegment

Question

Calling rebuild_hyb_matrix in remove_antisegment

Opened this issue 3 years ago · 3 comments

Dear developers,

I found that the hybridization matrix is rebuit everytime in remove_antisegment.
https://github.com/ALPSCore/CT-HYB-SEGMENT/blob/master/hybconfig.cpp#L69

Is it necessary? It seems that this line should be commented out as in other methods such as remove_segment.

The thing is that, at low temperature, the program often stops with an error message "in dgesv: info was not zero." This error is raised in invert function, which computes the inversion of large-size matrix, e.g., 100 x 100.

Best regards,
Junya Otsuki

Answer 1 · 2022-03-22T10:45:09.000Z

That looks wrong... I will check!

…

On Tue, Mar 22, 2022, 5:47 AM Junya Otsuki ***@***.***> wrote: Dear developers, I found that the hybridization matrix is rebuit everytime in remove_antisegment. https://github.com/ALPSCore/CT-HYB-SEGMENT/blob/master/hybconfig.cpp#L69 Is it necessary? It seems that this line should be commented out as in other methods such as remove_segment. The thing is that, at low temperature, the program often stops with an error message "in dgesv: info was not zero." This error is raised in invert function, which computes the inversion of large-size matrix, e.g., 100 x 100. Best regards, Junya Otsuki — Reply to this email directly, view it on GitHub <#18>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABW32RJW5U7GGK4IUUBR2S3VBGJMNANCNFSM5RKJ3U6A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Answer 2 · 2022-03-22T10:46:58.000Z

Thank you!

Answer 3 · 2022-10-11T08:31:45.000Z

Sorry, I dropped the ball here. It looks like this is a left over debug functionality, and it would be harmless to just remove it. Could you please try if it works when you uncomment it, and if it does then please make a pull request and we’ll commit it right away! Emanuel

…

On Mar 22, 2022, at 6:47 AM, Junya Otsuki ***@***.***> wrote: Thank you! — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABW32RPVWLV6XH3HBVTRAWLVBGQKZANCNFSM5RKJ3U6A>. You are receiving this because you commented.