add date column filter

Question

add date column filter

Closed this issue 12 years ago · 67 comments

Deleted user commented 13 years ago

Answer 1 · 2011-10-16T17:44:20.000Z

What to you want to do with this filter?

When you add a Enhancement or Feature, please give us a little description. We can help you.

Answer 2 · 2011-10-17T08:06:12.000Z

just date column in not rendering any filter in renderFilter function ... there should be a input or few selects like in form data widget

Answer 3 · 2011-10-17T08:51:36.000Z

Set a Range of date with inputs text
Set a Range of date with selects
Set a Date with inputs text
Set a Date with selects

What can we choose as a solution?
Add a different type for these solutions ? DateRangeInput, DateRangeSelect, DateInput, DateSelect?

Answer 4 · 2011-10-17T09:04:46.000Z

all of them :) ... we can add annotation options like range=true, mode="input/select"

Answer 5 · 2011-10-17T11:00:43.000Z

It gets complicated :(

Answer 6 · 2011-10-17T11:25:24.000Z

but Set a Range of date with inputs text will be enough

Answer 7 · 2011-11-17T10:38:53.000Z

maybe its not so difficult ... i'm planing to use form component transformers

Answer 8 · 2012-02-10T16:02:19.000Z

Any news about this feature ?

Answer 9 · 2012-02-17T16:35:04.000Z

what do you mean with "form component transformers" ?
i'm also interested in a date column filter.

I'm also working on a fork to add the possibility to select an operator for each filter ("like", "not like", "equal", "not equal", ...).

Answer 10 · 2012-02-17T18:44:02.000Z

Answer 11 · 2012-02-17T19:04:52.000Z

i was thinking about regexp but as i remember there was no regexp support in doctrine during source class creation, i would prefer operators instead of keywords

Answer 12 · 2012-02-17T19:12:33.000Z

there is support for operators in source class but input string need to be properly parsed in column during filter creation

Answer 13 · 2012-02-20T08:42:56.000Z

Actually I was thinking on a second select, containing different operators, depending on column type.

For exemple :

select column would have those operators: equal, different
text column: equal, different, containing, not containing, starting with, ending with
numeric column (ToDo): equal, different, lower, lower or equal, greater, greater or equal
date column: equal, different, after, before

Answer 14 · 2012-02-20T10:36:54.000Z

Good exemples, I like your ideas.
With a select, you can handle integers, dates too and a multiple selection.

@S0RIEN do you have already started the dev of these features?

Answer 15 · 2012-02-20T15:12:51.000Z

nop, don't have much time for this.. :(

Answer 16 · 2012-02-27T07:01:45.000Z

@ sterrien we should use https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php to transform date to string and vice versa

Answer 17 · 2012-05-04T12:09:52.000Z

Are you working on the daterange filter at the moment? if so, I'd happily test it, and of course help if at all possible - I'm after a data grid component for sf2 that can do date range filtering, and am reluctant to start writing my own (especially seeing there's already something like this bundle).

Answer 18 · 2012-05-04T12:12:49.000Z

Not yet. @sterrien do you want to implement it?

Answer 19 · 2012-05-04T20:32:12.000Z

The date filter would be great if implemented.

Answer 20 · 2012-05-04T21:44:08.000Z

I can try to do it. But not until wednesday ;-)

Answer 21 · 2012-05-04T21:59:34.000Z

Thanks sterrien. I'll try to do the export - or not - this week end.

Answer 22 · 2012-05-11T14:26:28.000Z

Hi guys, I am user of this bundle which is very well done and help me a lot. I am therefore very interested in the resolution of the search by range of date. Is this still in the pipeline ? I have a project to deliver within the next few days and it's a pain in the ass for me too. Thanks in advance for your help.

Answer 23 · 2012-05-11T14:53:04.000Z

@sterrien any news ?

Answer 24 · 2012-05-11T16:05:37.000Z

Nop, sorry. I don't have time these days.

Answer 25 · 2012-05-11T16:15:57.000Z

@dazealot seeing as sterrien is busy, do you want to get in touch with me? Maybe between the two of us, and with a little help/information from abhoryo, we can tackle implementing that particular feature ourselves. Next week I will have to deliver a first working version of the project I'm currently working on, and I'm 100% certain that date range filtering of the data will be among the very first things my manager will want added.

Answer 26 · 2012-05-11T16:39:48.000Z

I think you have to look at the RangeColumn class.
In the DateColumn class, you have to deal with the format of :

the posted dates
the date in your column
http://www.php.net/manual/en/datetime.format.php
http://www.php.net/manual/en/datetime.createfromformat.php

Answer 27 · 2012-05-11T18:55:40.000Z

Thanks @sterrien - so, if I understand this correctly, we will basically need to grasp what RangeColumn and DateColumn are doing exactly and how, then create a DateRangeColumn class, and deal with the formats and conversions thereof. Sound about right? I suppose the DateTimeToLocalizedStringTransformer that @S0RIEN mentioned will come in handy there at some point somewhere.

Answer 28 · 2012-05-12T09:44:34.000Z

@userfriendly I would like to help you in this but I don't think I don't have the capability to do a such thing, dates are relay a pain in the ass to deal with... Now a days it is mandatory that a dataGrid as date rang filtering.

Answer 29 · 2012-05-13T21:12:44.000Z

I've added DateTimeRange (datetimerange) and DateRange(daterange) columns with intputs.

Values are automatically displayed in locale date/datetime format.
Filter manage everything that a DateTime instance can understand. (2012-04-02, Apr 6, 2012, -6 weeks, next Monday 2012-05-01, `first monday of January 2012 ...)

Enjoy.

Answer 30 · 2012-05-13T21:53:28.000Z

so first of all thank you very much for the job. I've tried it on one of my DateTime column so i've pute --> type="datetimerange" in the grid annotation and now I have a error message concerning the local value.

An exception has been thrown during the rendering of a template ("The Symfony\Component\Locale\Stub\StubIntlDateFormatter::__construct() method's argument $locale value 'fr' behavior is not implemented. Only the 'en' locale is supported. Please install the 'intl' extension for full localization capabilities.") in RaligneBaseBundle::layout.html.twig at line 18.

Answer 31 · 2012-05-13T22:07:01.000Z

You have this error because INTL(ICU) extension is not activated or installed in your PHP. So by default Symfony manage only the locale 'en'.

I can perhaps add a fallback for users who have not the intl extension activated.

Answer 32 · 2012-05-13T22:15:55.000Z

I've added DateTime (datetime) and Date (date) columns too.

Answer 33 · 2012-05-13T22:23:56.000Z

@mdm1290 do you want a fallback with a format attribute like the old dateColumn ?

Answer 34 · 2012-05-13T22:36:18.000Z

I've try to add a Time and TimeRange column but I don't know how to extract the time of a DQL datetime. Does anyone know?

Answer 35 · 2012-05-13T22:40:26.000Z

okok my bad, I've activated them now and stile have an error while the rendering of the datagGrid,

Fatal error: Call to a member function format() on a non-object in C:\workspace\raligne\vendor\bundles\Sorien\DataGridBundle\Grid\Column\DateTimeRangeColumn.php on line 76
Call Stack

Answer 36 · 2012-05-13T22:48:21.000Z

@Abhoryo yes why not because the us format isn't really used else where than in the states lol

Answer 37 · 2012-05-13T22:50:17.000Z

locale="en" is set in parameter.ini?

translator: { fallback: %locale% } is uncommented in config.yml ?

Close your webBrowser and clear your cache.

Everything is green on this page http://localhost/Symfony/web/config.php -> re-check configuration ?

Answer 38 · 2012-05-13T23:02:15.000Z

Yes locale="en" is set

If i uncomment the translator line in config.yml it doesn't change anything and my translations don't work anymore

Answer 39 · 2012-05-13T23:07:27.000Z

Can you debug the $formatter variable?

Answer 40 · 2012-05-13T23:16:27.000Z

I have the head columns displayed but i have the error while rendering the row so I can't debug anything

Answer 41 · 2012-05-13T23:22:01.000Z

Can you try an error_log('class: '.get_class($formatter)); on line 75 of DateTimeRangeColumn.php ? And open your error.log file

Answer 42 · 2012-05-13T23:31:55.000Z

I've aded the line and I don't have any error.log in folder logs

Answer 43 · 2012-05-13T23:35:32.000Z

From what I found on the web this is definitely a problem of the intl extension installation.

Do you use easyPHP or WampServer on Windows ?
Do you have in your PATH variable system the directory where the files icu*.dll of PHP are ?
Can you look at the php error log file, maybe it tells you that this extension doesn't work because of something.

Answer 44 · 2012-05-13T23:40:17.000Z

I've aded the line and I don't have any error.log in folder logs

the log folder of your server not the folder log of symfony.

Answer 45 · 2012-05-13T23:40:38.000Z

I use WampServer, I don't have the path in my system variables when I go in the php_error.log it is empty

Answer 46 · 2012-05-13T23:47:35.000Z

With WampServer you have to append the directory path of these icu*.dll files in the PATH variable system of Windows and close and restart Wampserver.

I'll try tomorrow to add a force format.

Answer 47 · 2012-05-14T07:33:07.000Z

okay so now I added the path C:\wamp\bin\php\php5.3.10\icu*.dll to my variable system and I stile have the same problem

Answer 48 · 2012-05-14T14:38:37.000Z

Ne mets pas icu*.dll juste le répertoire. Et relance ton Pc.

Answer 49 · 2012-05-14T14:43:54.000Z

ah alors j'avais déjà une variable d'environement path pointant sur C:\wamp\bin\php\php5.3.10;

Answer 50 · 2012-05-14T14:59:59.000Z

Oki je suis à cours d'idée. Sur easyPhp marche directement. Bref je vais remettre le paramètre format.

Answer 51 · 2012-05-14T15:08:49.000Z

Okay je vais test avec easyPhp alors.

Si jamais j'ai une autre erreur depuis que j'ai mis à jours le bundle. Lorsque j'utilise le filtre pour une column de type text j'ai se message d'erreur qui vient.

An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 1 in C:\workspace\raligne\vendor\bundles\Sorien\DataGridBundle\Grid\Source\Entity.php line 187") in RaligneBaseBundle::layout.html.twig at line 12.

Answer 52 · 2012-05-14T15:50:47.000Z

J'ai eu la même, il faut faire un cache:clear. En plus je pense que cette fonction ne sert plus à rien vu le système que j'ai rajouté.

Answer 53 · 2012-05-14T21:21:21.000Z

I've added the format attribute and add a fallback format.

Answer 54 · 2012-05-15T10:46:57.000Z

Trop beau ca marche!!! Merci pour tout!!

Answer 55 · 2012-05-15T10:58:40.000Z

mise a part ca j'ai toujours cette erreur

An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 1 in C:\workspace\raligne\vendor\bundles\Sorien\DataGridBundle\Grid\Source\Entity.php line 187") in RaligneBaseBundle::layout.html.twig at line 7.

j'ai beau clearer le cache et les filtres ne marche toujours pas sur les type text

Answer 56 · 2012-05-15T12:34:03.000Z

Le cache:clear c'est bien mais il y a toujours des problèmes dans certains cas car le cache n'est pas vraiment cleared.

Essaie de supprimer tout simplement les répertoires qui se trouvent dans le répertoire cache et ressaie.

Answer 57 · 2012-05-15T12:44:46.000Z

Oui je clear toujours le cache à la sauvage si ca marche pas la commande cache:clear
j'ai même

supprimé le cache du navigateur.
publié les assets
réinstallé le bundle

mais rien ne change, l'autre jours un simple cache:clear et c'etais bon mais la...

Answer 58 · 2012-05-15T13:44:43.000Z

Hum, cela vient d'un problème de l'utilisation d'une colonne avec pour opérateur un LIKE. Utilises-tu une colonne spécifique que tu as créé toi-même ?

Quelques sont tous les types de tes colonnes ?

Answer 59 · 2012-05-15T13:50:18.000Z

J'ai crée aucune colonne spécifique, mise à part la column datetimerange, les autres columns sont de type text. C'est lorsque j'utilise le filtre sur ces columns de type text que ca m'affiche ce message d'erreur. et c'est comme ca sur tout mes grids avec des filtres text

Answer 60 · 2012-05-15T15:12:26.000Z

Ok, j'ai compris. Merci, je corrigerai en rentrant ce soir.

Answer 61 · 2012-05-15T20:34:26.000Z

Works for me! Merci

Answer 62 · 2012-05-15T21:09:03.000Z

C'est possible de mettre un contrôle de saisi sur le filtre des dates? Car la un utilisateur peut rentré n'importe quoi (lettres) et ça fais une erreur.

Answer 63 · 2012-05-15T21:30:57.000Z

Ah, j'ai oublié ce cas.

Answer 64 · 2012-05-15T23:57:14.000Z

Voilà j'ai ajouté un contrôle. J'espère que le comportement que j'ai appliqué vous conviendra.

Si la valeur d'un filtre ne correspond pas à une date ou datetime, il est ignoré et remis à vide.

Exemple avec un daterange:
Si la personne saisie : From = 2012-04-04 et To = fgzegze Cela sera équivalent à date >= 2012-04-04

Je pourrais bien sûr faire l'inverse et lancer une requête sans résultat du style date >= 2012-04-04 and date <= fgzegze

Bref à vous de me donner votre avis.

Answer 65 · 2012-05-16T12:47:49.000Z

Sinon, une petite idée m'est venue. Que pensez-vous d'un filtre dynamique ?
@sterrien a ajouté la possibilité de choisir de l'opérateur du filtre. Ca marche niquel et grâce à ça on peut envisager une autre évolution.

Un filtre de type text(input) qui si on choisit l'opérateur >= ou > fait apparaitre un second input pour faire un range.

De même, quand on choisi l'opératuer = ou like, d'autres inputs apparaissent pour pouvoir filtrer sur plusieurs termes à la fois.

Qu'en pensez-vous ?

Answer 66 · 2012-05-16T14:57:57.000Z

Des filtres dynamique serait une bonne évolution du truc, ou des filtres en autocompletion, mais ca c une autre histoire...

Answer 67 · 2012-05-16T15:04:34.000Z

Ce que je propose nécessite peu de javascript. L'autocompletion serait complexe car il faut éviter d'utiliser des framework. De plus l'autocompletion se greffe généralement automatiquement donc c'est plus quelque chose à implémenter à côté chacun par ses soins.