refactor: move result logging to `train_baseline_model_from_schema`

Question

refactor: move result logging to `train_baseline_model_from_schema`

Closed this issue 9 months ago · 3 comments

MartinBernstorff commented 10 months ago

By results, I mean logging the TrainingResult, i.e. the optimised metric and the "eval_df".

Currently, we duplicate it in both of the trainers. Since result logging is needed no matter which trainer you use, and all trainers must return a TrainingResult, it think it's better to move this one layer out.

What do you think @HLasse?

Answer 1 · 2024-03-13T10:06:50.000Z

Yep, seems reasonable!

Answer 2 · 2024-03-27T13:03:37.000Z

This issue is stale because it has been open for 14 days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

Answer 3 · 2024-04-03T13:04:40.000Z

This issue was closed automatically. Feel free to re-open it if it's important.