Aarhus-Psychiatry-Research/psycop-common

dev: stabilise transitive dependencies

Closed this issue · 3 comments

MartinBernstorff commented

We've had our first transitive dependency test-error (`d95414f) on #985).

To avoid these in the future, I think we should pin transitive dependencies.

Seeing as we're unlikely (? @HLasse) to move to the anaconda-enterprise server anytime soon, it's perhaps OK that the requirements files move to pyproject.toml.

Options:

  • Fix this specific bug and do nothing. Keeps us open to transitive-dependency drift.
  • As part of migrating to kubeflow, we probably want to build a container and gate it by tests passing.
  • Migrate to rye. I've been using rye for the past 6 months without any issues. Its virtual environments are compatible with the standard, so we can still use other package managers to install into it. Unsure if it installs into conda environments. AFAICT, we only need to learn 3 commands: rye sync, rye add and rye remove.
  • Migrate to poetry, pdb or another choice.

I think just fixing this dependency is the most pragmatic choice, but would love to talk about this! @bokajgd, @sarakolding, @HLasse, @erikperfalk, you guys will live with these choices over time, so you should be the ones to make it 👍

sarakolding commented

@MartinBernstorff @HLasse @bokajgd @erikperfalk should we set up a time to discuss this?

  • 👍1
github-actions commented

This issue is stale because it has been open 1+ days with no activity. Feel free to either 1) Remove the stale label, 2) Comment or 3) Add the 'evergreen' label to make it immune. . If nothing happens, this will be closed in 7 days.

github-actions commented

This issue was closed automatically. Feel free to re-open it if it's important.