Building on RHEL-7 x86_64
Closed this issue · 5 comments
okellogg commented
Building on Red Hat Enterprise Linux Server release 7.2, I got the following error:
make -C trace_adapters/valgrind VALGRIND_PREFIX?=/usr
make[1]: Entering directory `/tools/gnatcoverage/tools/gnatcov/trace_adapters/valgrind'
gcc -O2 -g -fno-strict-aliasing -fno-builtin -fno-stack-protector -Wall -Wmissing-prototypes -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-declarations -Wno-format-zero-length -Wno-long-long -Wno-pointer-sign -o coverage-amd64-linux cov_traces.o cov_main.o \
-static -nodefaultlibs -nostartfiles -u _start -Wl,--build-id=none -Wl,-Ttext=0x38000000 /usr/lib/valgrind/libcoregrind-amd64-linux.a /usr/lib/valgrind/libvex-amd64-linux.a -lgcc
gcc: error: /usr/lib/valgrind/libcoregrind-amd64-linux.a: No such file or directory
gcc: error: /usr/lib/valgrind/libvex-amd64-linux.a: No such file or directory
make[1]: *** [coverage-amd64-linux] Error 1
make[1]: Leaving directory `/home/akellol/tools/gnatcoverage-master/tools/gnatcov/trace_adapters/valgrind'
make: *** [adapter-valgrind] Error 2
It turns out that on RHEL7, the valgrind libs are installed in /usr/lib64 but the build expects /usr/lib.
The build was successful using following patch to trace_adapters/valgrind/Makefile :
--- trace_adapters/valgrind/Makefile.orig 2019-11-19 10:17:38.438856776 +0100
+++ trace_adapters/valgrind/Makefile 2019-11-19 12:18:25.853043992 +0100
@@ -6,7 +6,7 @@
#########
VALGRIND_INCLUDE=$(VALGRIND_PREFIX)/include/valgrind
-VALGRIND_LIBS=$(VALGRIND_PREFIX)/lib/valgrind
+VALGRIND_LIBS=$(wildcard $(VALGRIND_PREFIX)/lib*/valgrind)
CPP_FLAGS=-I. -I$(VALGRIND_INCLUDE) \
-DVGA_$(VALGRIND_ARCH)=1 -DVGO_linux=1 \
pmderodat commented
Hello again @okellogg,
Your suggestion seems to be a good idea. Would you be okay to create a pull request for your patch? Thank you in advance!
okellogg commented
Hi @pmderodat,
Okay, I'll do that.
By the way, I noticed that there is a trace_adapters/valgrind/Makefile.am but AFAICT it is not used for generating the Makefile.
Can I remove that file as part of my pull request?
okellogg commented
Hello @pmderodat,
The pull request says
Some checks haven’t completed yet > 1 pending check
<https://cla-assistant.io>
*> license/cla * Pending — Contributor License Agreement is not signed yet.
Is this per project?
A CLA should be on file in the context of PolyORB
<https://github.com/AdaCore/PolyORB>, is that sufficient?
Thanks for clarifying,
Oliver
…On Thu, Nov 21, 2019 at 3:49 PM Pierre-Marie de Rodat < ***@***.***> wrote:
Hello again @okellogg <https://github.com/okellogg>,
Your suggestion seems to be a good idea. Would you be okay to create a
pull request for your patch? Thank you in advance!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=AAEAWBNXELDDBEKBNHG66T3QU2NWHA5CNFSM4JPCG3XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE2PD2Q#issuecomment-557117930>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAWBIP7A6LI6EN5CGMKUTQU2NWHANCNFSM4JPCG3XA>
.