The About box is missing the logo on Mac, and the package-version is not populated.
Closed this issue · 3 comments
Adrienne200 commented
AYAB software version: 0.99.0-rc4
Computer/OS: Intel Mac, Big Sur
Knitting machine: KH910
AYAB hardware: Interface
Do Help - About
Expected: A box with the logo, and a version number.
On Mac it's a big empty space where the logo should be, and
All Yarns Are Beautiful PACKAGE_VERSION
On Windows the AYAB logo shows up correctly, but the package-version issue is the same.
![Screen Shot 2024-03-16 at 3 41 34 PM](https://private-user-images.githubusercontent.com/24358225/313435496-971165a6-2681-4322-b371-333fc984d0d2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTk2MDUsIm5iZiI6MTcyMTc1OTMwNSwicGF0aCI6Ii8yNDM1ODIyNS8zMTM0MzU0OTYtOTcxMTY1YTYtMjY4MS00MzIyLWIzNzEtMzMzZmM5ODRkMGQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIzVDE4MjgyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVhM2ExZTllMmQ4Y2EyNjY4YWU2YTU4Njk4ZjJmNWYyZGI5ZGM4ZjRmZjgzYmQwZWY1ZjgzMmMwMDUyYzVmNTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pPu-7ZBgZ7g6XOsc5OJhbvcNFWbsPBJardXg42YAA3c)
X-sam commented
This is fixed in #637
…On Sat, Mar 16, 2024, 7:22 PM Adrienne200 ***@***.***> wrote:
AYAB software version: 0.99.0-rc4
Computer/OS: Intel Mac, Big Sur
Knitting machine: KH910
AYAB hardware: Interface
Do Help - About
Expected: A box with the logo, and a version number.
On Mac it's a big empty space where the logo should be, and
All Yarns Are Beautiful PACKAGE_VERSION
On Windows the AYAB logo shows up correctly, but the package-version issue
is the same.
Screen.Shot.2024-03-16.at.3.41.34.PM.png (view on web)
<https://github.com/AllYarnsAreBeautiful/ayab-desktop/assets/24358225/971165a6-2681-4322-b371-333fc984d0d2>
—
Reply to this email directly, view it on GitHub
<#644>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSQJ572KDMIS3ORQK7U5RDYYTHZ5AVCNFSM6AAAAABEZV32GKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TAMZTHA2TEMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
X-sam commented
Logo is fixed, PACKAGE_VERSION
still isn't.
jonathanperret commented
I can confirm that #661 (0.99.0-test
) fixes the version number display in the about box, this can be closed I think.