Think about U_RA_DS epoch length
Opened this issue · 0 comments
t-b commented
One thing I noticed when fixing a ITC vs. NI/SUTTER difference for U_RA_DS is the following:
In PSQ_Ramp for ITC hardware as epochEnd for U_RA_DS DimSize(daqDataWave, ROWS) - 1
is used. For ITC this wave is always the next power of two greater than the DA channel wave.
As result epochEnd is in all cases beyond the size of the DA channel wave and the epoch gets adjusted after the acquisition through EP_AdaptEpochInfo to DimSize(DAChannel, ROWS)
. If this is really intended one could just use inf
as epochEnd.
For NI/SUTTER the end is DimSize(DAChannel, ROWS) - 1
which is in that sense inconsistent with ITC for the same epoch. With the current epoch definition DimSize(DAChannel, ROWS)
would make sense, but break compatibility with old data.
Originally posted by @MichaelHuth in #2106 (comment)