AllenInstitute/MIES

Wavebuilder: Outputs the same noise curve for different filter orders

Opened this issue · 2 comments

t-b commented

For epoch type noise, duration 1000, amplitude 1, low pass 100, high pass 10 we get the same curves for filter order 5 and 6, and 7 and 8 and so on.

I guess is this is a property of the created filter.

Same issue with the butterworth SF operation.

t-b commented

Asked WM for help.

t-b commented

WM confirmed that the order for bandpass filters will be made one larger if it is odd as the internal implementation requires an even value.

Remedies:

  • Fix the order up for the user with a warning message
  • Don't allow to input odd numbers for bandpass/bandstop in the Wavebuilder GUI
  • SFH_Assert in SF for butterworth