Sweepbrowser does not support data from multiple devices in general
Opened this issue · 2 comments
When given a sweepNo as argument with the simple FindValue approach the function returns only for the first hit.
Thus, we have code paths that are not aware of sweeps loaded from multiple experiment.
e.g. everything that uses also BSP_GetSweepDF
Review all functions that use:
SB_GetSweepDataFolder
, BSP_GetSweepDF
General changes:
Add a column a SweepMap with CRC of sweep number, experiment name, device name. Then function take these as argument, resolve indice through finding that CRC in SweepMap.
Change SB functions to use the mentioned three arguments for IDing a sweep.
Before the GUI fixes we need to fix the code, partly done in #2109. The full fix would go over all relevant BSP/SB functions and revise them so that they are able to uniquely identify a sweep given sweep number/device/experiment.
GUI wise we need to fix three locations:
- OVS panel
Options:
1.) We could either have three columns (sweeps, device, experiment) in the listbox. The user could then resort the listbox by clicking on the column label.
2.) We have somes kind of tree hierarchy where the sweeps are leaves and device/experiment are nodes. No expand/collapse support.
3.) Or we introduce two columns with background colors. The columns would color code the experiment and device. Each device type would have a fixed base color. Show the legend somewhere. Optional symbol on top of each color for better readability.
-
Selection popupmenu. Should have the device/experiment shown as well. Ellide experiment names to only show unique characters, at least ~10.
-
Dashboard
Same options as for OVS, but we don't have sweeps here but SCI's.