Downloads - firefox

[msmicker]

It appears Spring is generally compatible with Firefox, but we noticed download options are not functioning in Firefox. I was able to resolve by a small update to the downloadFile function. It is a one line change suggested from this link:
https://support.mozilla.org/en-US/questions/968992

Apparently the hidden link being created needs to be attached to the DOM but not in Chrome.

Before this line -

SPRING_dev/scripts_1_6_dev/forceLayout_script.js

Line 577 in efe6ab4

hiddenElement.click();

I added this to attach to DOM:
document.body.appendChild(hiddenElement)

[calebweinreb]

Thanks! We'll make this change

…

On Fri, Mar 1, 2019 at 8:09 PM msmicker ***@***.***> wrote: It appears Spring is generally compatible with Firefox, but we noticed download options are not functioning in Firefox. I was able to resolve by a small update to the downloadFile function. It is a one line change suggested from this link: https://support.mozilla.org/en-US/questions/968992 Apparently the hidden link being created needs to be attached to the DOM but not in Chrome. Before this line - https://github.com/AllonKleinLab/SPRING_dev/blob/efe6ab4526688dbafd928091dde1c3cf3def2a30/scripts_1_6_dev/forceLayout_script.js#L577 I added this to attach to DOM: document.body.appendChild(hiddenElement) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF3OspnDCHnGEvwxcY2iFldtnmVdf1hFks5vSc88gaJpZM4baErE> .