In glTF Tools 2.3.0, the three.js button is sticking out of the menu
cx20 opened this issue · 5 comments
I tried changing the CSS
font part locally as a trial. 13px
seems to fit in the menu.
gltf-vscode/pages/previewModel.css
Line 7 in 7c4c080
font size | menuUI |
---|---|
font: 13px sans-serif; | |
font: 14px sans-serif; | |
font: 15px sans-serif; |
When we used sans-serif
, the actual font is different between Japanese fonts
and English fonts
, so the size seems to be different.
https://twitter.com/clockmaker/status/859263366769946624
lang | sample |
---|---|
"ja" | |
"en" |
Below is the result of trying sans-serif
font using Chrome browser on Japanese Windows 10.
https://w3g.jp/sample/css/font-family#sans-serif
https://w3g.jp/sample/css/font-family#japanese
It seems that the sans-serif
font is actually assigned to the Meiryo
font.
I haven't tried it because I don't have an English Windows 10, but I think the font assigned to sans-serif
is probably different.
Thanks @cx20. The sans-serif font in English is "Arial".
I think the box needs to be wider. In particular, if #mainUI.width was 325px
, maybe it would fit?
Also I wonder if the UI is too wide now with 4 buttons across, maybe on thinner windows it could collapse to a 2x2 arrangement of buttons.
Thanks @emackey.
he sans-serif font in English is "Arial".
I learned a lot. Thank you for the information.
if #mainUI.width was 325px, maybe it would fit?
Yes, 325px
is just barely enough, so 330px
looked like a good choice. I've tried several combinations of main UI sizes and fonts.
(If I make a table in markdown, the images in the cells are automatically resized, so I combined them into one image in Excel for comparison.)
Also I wonder if the UI is too wide now with 4 buttons across, maybe on thinner windows it could collapse to a 2x2 arrangement of buttons.
I agree. we might want to change the layout to 2x2 if we have a smaller window size. if we have more glTF Viewers, we might need to think about 3x2, etc.