AplaProject/apla-tests

Issues

• use helper functions that accept node config, instead of passing each parameter

  #65 opened 7 years ago by potehinre
  0

• use for cycle there

  #64 opened 7 years ago by potehinre
  0

• fix grammar in all repository

  #63 opened 7 years ago by potehinre
  0

• remove copypaste in test_contract_db[Insert|Update|UpdateExt]

  #62 opened 7 years ago by potehinre
  0

• why not just test_fixtures, instead of all that copypaste methods?

  #61 opened 7 years ago by potehinre
  0

• why not just use function like loadJSONFile

  #60 opened 7 years ago by potehinre
  0

• in that case you should use for cycle

  #59 opened 7 years ago by potehinre
  0

• Prints in code are prohibited

  #15 opened 7 years ago by potehinre
  1

• if possible, do all in functions parameters call, less code is better

  #16 opened 7 years ago by potehinre
  0

• Use python dict syntax, instead of creating the dict, and then assigning values to each element

  #17 opened 7 years ago by potehinre
  0

• Use of """ """

  #18 opened 7 years ago by potehinre
  0

• Maybe better to use for loop, like tables = [table list]; for table in tables:

  #4 opened 7 years ago by potehinre
  0

• Using global variable, and filling it with different data, depending on context in very bad idea, it's better to each function return own config

  #5 opened 7 years ago by potehinre
  0

• Code duplication, also used in contract_function_test, so move to utils, or create own test case class and inherit from it

  #6 opened 7 years ago by potehinre
  0

• jwtToken?

  #7 opened 7 years ago by potehinre
  0

• for i in range(1, 10):

  #8 opened 7 years ago by potehinre
  0

• better not to call that assert, but key/keys

  #9 opened 7 years ago by potehinre
  0

• did you mean sourceCode?

  #10 opened 7 years ago by potehinre
  0