Upgrade guide required
bcalik opened this issue · 5 comments
bcalik commented
Description of this repo says "An upgradable boilerplate ...", but there isn't any upgrade guide available.
tirthbodawala commented
Apologies for the same, I am working on Docs. But by upgradable, we mean,
you can upgrade from any version of PawJS (core library) to new version,
without breaking the application.
…On Tue, 5 May, 2020, 7:40 AM Burak Çalık, ***@***.***> wrote:
Description of this repo says "An upgradable boilerplate ...", but there
isn't any upgrade guide available.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#184>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN76FY2GRBLOQXOBJZF3RP5YRZANCNFSM4MZGTLRQ>
.
bcalik commented
Sorry I may still not be able to understand what actually "upgradable" refer to, thats sounds a little weird to me. For example package.json doesn't contain react library itself and pawjs core actually require react, and react itself may get a breaking change. So pawjs would bump the version to 4 from 3, and that is not upgradable.
tirthbodawala commented
I undesratand, and that is a very good point actually, I am now planning to
move react as Peer Dependency, thus handled by user himself. Thank you for
pointing that out
…On Tue, 5 May, 2020, 9:33 AM Burak Çalık, ***@***.***> wrote:
Sorry I may still not be able to understand what actually "upgradable"
refer to, thats sounds a little weird to me. For example package.json
doesn't contain react library itself and pawjs core actually require react,
and react itself may get a breaking change. So pawjs would bump the version
to 4 from 3, and that is not upgradable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN7Z76UUWLFLWXD44QVLRP6FZZANCNFSM4MZGTLRQ>
.
bcalik commented
That was an example, I'm not really sure if you should move react as peer dependency or not. But thank you for your reply and interest.
tirthbodawala commented
No, Thank you. I will see what term I should use as description so it
represents what it exactly does. It has been a valuable conversation
…On Tue, 5 May, 2020, 9:52 AM Burak Çalık, ***@***.***> wrote:
That was an example, I'm not really sure if you should move react as peer
dependency or not. But thank you for your reply and interest.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWDN7YAETGQEBFDC3UMEHTRP6IABANCNFSM4MZGTLRQ>
.