AvaLido/contracts

Issues

• [Lido] Beneficiary can be immutable

  #172 opened 2 years ago by 0xchaosbi
  1

• [Lido] Payable term for claimUnstakedPrincipals

  #170 opened 2 years ago by 0xchaosbi
  1

• [Lido] Pub keys ordering can be checked by SC code

  #167 opened 2 years ago by 0xchaosbi
  0

• [A3] Inaccurate comment in the ValidatorHelpers library

  #209 opened 2 years ago by 0xchaosbi
  0

• [L4] Recent changes have weakened the protocol’s reentrancy protection

  #206 opened 2 years ago by 0xchaosbi
  0

• [L1] Some Oracle view functions might return inaccurate data if called during an update of node ids

  #203 opened 2 years ago by 0xchaosbi
  0

• [A1] Gas optimization

  #207 opened 2 years ago by 0xchaosbi
  0

• [M2] Unbounded loop DoS might still be possible under specific conditions

  #202 opened 2 years ago by 0xchaosbi
  1

• Remove "NodeId-" from data written to chain

  #189 opened 2 years ago by 0xchaosbi
  0

• [Lido] deposit method has no _referral arg

  #184 opened 2 years ago by 0xchaosbi
  0

• [Lido] Unnecessary timestamp fields

  #185 opened 2 years ago by 0xchaosbi
  1

• [Lido] No args for event NodeIDListChanged

  #178 opened 2 years ago by 0xchaosbi
  1

• [Lido] Possible invalid return value in currentReportableEpoch

  #179 opened 2 years ago by 0xchaosbi
  1

• [Lido] Extra gas spending if request is full already

  #169 opened 2 years ago by 0xchaosbi
  0

• [Lido] Indexed string in events will be emitted as hashes only

  #173 opened 2 years ago by 0xchaosbi
  0

• Enable MpcManager to coordinate MPC work flow

  #218 opened 2 years ago by Zealy-Rockx
  0

• Select validators for stake that won't cause errors of "validator would be over delegated".

  #217 opened 2 years ago by Zealy-Rockx
  1

• Limit daily max staking requests from AvaLido smart contract and make this item configurable

  #216 opened 2 years ago by Zealy-Rockx
  0

• Support key rotation

  #214 opened 2 years ago by gl-rockx
  0

• Support Failed Task

  #212 opened 2 years ago by gl-rockx
  0

• [A4] Compiler bugs

  #210 opened 2 years ago by 0xchaosbi
  0

• [A2] No-op in MpcManager::joinRequest

  #208 opened 2 years ago by 0xchaosbi
  0

• [L3] Functions responsible for the partial initialization of AvaLido can be called multiple times

  #205 opened 2 years ago by 0xchaosbi
  0

• [L2] Wasteful check in MpcManager::createGroup

  #204 opened 2 years ago by 0xchaosbi
  0

• [M1] MpcManager::_isSortedAscendingOrder allows same keys

  #201 opened 2 years ago by 0xchaosbi
  0

• [H1] MpcManager::reportGeneratedKey not updating the status of keygens may block the system

  #200 opened 2 years ago by 0xchaosbi
  0

• [Lido] Sanity checks for setters

  #171 opened 2 years ago by 0xchaosbi
  1

• [Lido] No getter for users withdraw requests

  #174 opened 2 years ago by 0xchaosbi
  1

• [Lido] Empty default payable method

  #176 opened 2 years ago by 0xchaosbi
  2

• [Lido] No handler methods for unaccountedBalance

  #177 opened 2 years ago by 0xchaosbi
  1

• Filter oracle node ids before writing to chain

  #188 opened 2 years ago by 0xchaosbi
  1

• [Lido] Payment split shares use integers instead of BP

  #175 opened 2 years ago by 0xchaosbi
  1

• [Lido] Usage of simple (a x b / c) instead of MulDiv

  #181 opened 2 years ago by 0xchaosbi
  0

• [Lido] Someone could enforce centralized node id

  #183 opened 2 years ago by 0xchaosbi
  1

• [Lido] lidoFeeAddress should be a smart contract

  #182 opened 2 years ago by 0xchaosbi
  1

• [Lido] Possible inconsistent stAVAX burns due to rounding

  #165 opened 2 years ago by 0xchaosbi
  1

• [Lido] Unable to unstake funds for a non-EOA account with non-trivial receive func

  #164 opened 2 years ago by 0xchaosbi
  1

• [Lido] minimum unstake request amount is not enforced

  #166 opened 2 years ago by 0xchaosbi
  1

• [Lido] Inconsistent docs for requestWithdraw

  #168 opened 2 years ago by 0xchaosbi
  1

• [Lido] Inconsistent docs for stAVAXToAVAX and avaxToStAVAX

  #180 opened 2 years ago by 0xchaosbi
  1

• [Dedaub] A3: Functions responsible for setting/updating numeric protocol parameters could define bounds on these values

  #131 opened 3 years ago by 0xchaosbi
  4

• [Dedaub] A6: Unused UnstakeRequest struct field

  #134 opened 3 years ago by 0xchaosbi
  2

• [Dedaub] A2: Check in AvaLido::fillUnstakeRequests is always true

  #130 opened 3 years ago by 0xchaosbi
  2

• [Dedaub] A11: compiler bugs in Solidity 0.8.10

  #139 opened 3 years ago by 0xchaosbi
  1

• [Dedaub] A4: AvaLido::claim might revert with ClaimTooLarge error

  #132 opened 3 years ago by 0xchaosbi
  1

• [Dedaub] A10: hasAcceptibleUptime misspelled

  #138 opened 3 years ago by 0xchaosbi
  0

• [Dedaub] A9: AvaLido::stakePeriod contradicts with ValidatorSelector::minimumRequiredStakeTimeRemaining

  #137 opened 3 years ago by 0xchaosbi
  0

• [Dedaub] A8: AvaLido::claimUnstakedPrincipals gas optimization

  #136 opened 3 years ago by 0xchaosbi
  0

• [Dedaub] A7: OracleManager::getWhitelistedOracles can be made external

  #135 opened 3 years ago by 0xchaosbi
  0

• [Dedaub] A5: Unused storage variables

  #133 opened 3 years ago by 0xchaosbi
  0