Avanade/CoreEx

Clarification on "Breaking Change" in "patch" point release

Closed this issue · 1 comments

sean-bloch commented

Not personally urgent, as I am following the project but have not made any implementations yet. However, I noticed the change note in [https://github.com/Avanade/CoreEx/compare/v1.0.11...v1.0.12]

Enhancement: Breaking change: The SqlServer specific capabilities within CoreEx.Database project/assembly have been moved to a new CoreEx.Database.SqlServer project/assembly

Could the documentation at [https://github.com/Avanade/CoreEx/blob/main/CONTRIBUTING.md] be updated to include guidelines on the versioning strategy specific to CoreEx? The documentation references the aspnetcore "Engineering Guidelines" which describe a different versioning strategy.

Thanks.

chullybun commented

Hi @sean-bloch, thanks for calling this out. This is indeed an oversight with respect to the versioning, and you are indeed correct we should be adjusting the version numbers in alignment with SemVer. The next version in progress will be following the appropriate versioning guidelines and will correct accordingly.

Thanks again for the feedback, much appreciated. Keep the comments, and maybe future pull requests, coming :-)