AxFoundation/strax

Lone hit area

Opened this issue · 4 comments

h['area'] = (
r['data'][start:end].sum()
+ (r['baseline'] % 1) * (end - start))

If we make the lone hits area also normalized according to PMT adc_to_pe like the peaklets instead of [ADC x samples], will it cause trouble elsewhere?

We would need to check where it is called. Would there be a big benefit changing it into pe?

Thanks for the quick response @WenzDaniel! Since the gain model is a time-dependent correction, people interested in lone hits properties like area, DPE component or stability need to fetch the corrections themselves and correct run-by-run. I think it's nice if we can do this at the basement level.

Maybe @a1exndr and @PALOMA can comment on the influence on the lone hit gain correction.

We can change it if needed. But this requires some careful checks and testing.