Azure/counterfit

Inconsistent attribute and method names

lil1n opened this issue · 1 comments

lil1n commented

Several issues were faced while trying out counterfit.

Upon starting counterfit and providing the command new -n test, an error 'AttributeError' was encountered.

  • new.py referenced an attribute named targets_path in config.py but config.py does not seem to have an attribute named targets_path declared or defined
  • This was resolved by adding a line to declare an attribute named targets_path with the path directed to the "targets" directory in config.py

The above issue appears to be the same issue as the first bullet point in issue #82

After resolving this issue, several other issues of similar nature were encountered:

  • new.py referenced add_targets() in state.py but state.py do not any method named add_targets() declared or defined
  • new.py referenced load_targets() in state.py but state.py do not any method named load_targets() declared or defined

After resolving the above issues, another exception named 'TypeError' was encountered with the message: 'NoneType' object is not callable. This issue was traced back to be from line 77 of new.py.

Other than the new command, the command predict -i range(10) (as mentioned in DEMO1-satellite.md) also does not produce the same output as documented. This appears to be the same issue as the second bullet point in issue #82

Hey sorry to bother you, did you fix in anyway the TypeError issue? i'm at exactly your same point :(