Poetry cannot install msal-extensions

Question

Poetry cannot install msal-extensions

chlowell opened this issue 4 years ago · 5 comments

portalocker~=1.6;platform_system=='Windows'",
portalocker~=1.0;platform_system!='Windows'"

make msal-extensions impossible to install with Poetry due to python-poetry/poetry#1238. Although this is a known Poetry bug, it could presumably be avoided if msal-extensions didn't have these platform-specific requirements. Given that the latest portalocker is 1.7.1, are they still necessary?

Answer 1 · 2020-07-22T00:49:02.000Z

@bluca You and us tried very hard (at exact 3 months ago) to allow using prior 1.6.0 portalocker on older Linux distributions. What if we bump it up to portalocker~=1.6 on all platforms this time?

Answer 2 · 2020-07-22T07:48:08.000Z

I think all versions can be supported here, thus relaxing the requirements in setup.py. For example it looks like versions 1.7.0 and 1.7.1 just added minor fixes, no compatibility was removed. So you could have >= 1.0 on Linux and >= 1.6 on Windows (I think there were Windows-specific fixes in that release)

Answer 3 · 2020-07-22T21:06:46.000Z

Discussed with @bluca off-line. It would be fine if we bump our dependency to consistent portalocker~=1.6 on all platforms. Luca explained that a Linux package maintainer could choose to ignore setup.py and still use an older version of dependency. (For example, as of today, stable portalocker on Debian is still at 1.3, similar situation on Ubuntu). But such an outside-of-setup.py dependency may not continue to work in the long run.
Alternatively, this issue can probably be resolved by using poetry 1.1.0a2, currently in preview, and stable version is coming at Aug.

We incline to not make any changes from our side.

Answer 4 · 2020-11-05T21:06:22.000Z

I'm having this issue again with poetry version 1.1.2

When I try to do poetry add azure-identity I get this infinite loop:


1: selecting azure-identity (1.4.1)
   1: fact: azure-identity (1.4.1) depends on azure-core (>=1.0.0,<2.0.0)
   1: fact: azure-identity (1.4.1) depends on cryptography (>=2.1.4)
   1: fact: azure-identity (1.4.1) depends on msal (>=1.3.0,<2.0.0)
   1: fact: azure-identity (1.4.1) depends on msal-extensions (>=0.2.2,<0.3.0)
   1: fact: azure-identity (1.4.1) depends on six (>=1.6)
   1: selecting azure-identity (1.4.1)

Answer 5 · 2020-11-05T21:25:18.000Z

@alexkyllo Previous conversation in that Poetry issue got confirmed that Poetry fixed the problem since 1.1.0a2. If you find this issue again in their later version, it sounds like a regression. Would you consider create/reopen an issue there?