BUGS-NYU/schedge

Suggested Renamings

Closed this issue · 4 comments

NicholasLYang commented

I'm not a huge fan of some key names. I understand that this is totally subjective, but I'd like to propose a few renames:

"subject" -> "code"
"sectionName" -> "name"
"sectionCode" -> "code"

Alternatively we could rename all instances of code to id, as at least I'm using them as pseudo-primary keys in Redux.

NicholasLYang commented

Alt-Alternatively what do y'all think about including an actual primary key, as now that I think about it, trusting NYU Albert to give unique codes is pretty foolish

A1Liu commented

lol yeah they don't actually provide anything unique; we use our own primary keys and don't have any unique indices.

A1Liu commented

Changes to names have been made.

  • 👍1
NicholasLYang commented

Thanks for doing it so quickly, but in the future if/when we have people relying on the API we'll have to be careful about breaking changes