Making a change in the advanced settings sets "Cooler minimum ON time" 0
Closed this issue · 3 comments
If I set my minimum on time, send to core, then update from core to verify setting, it appears correct. However, making any other changes, such as max difference or Beer-to-Fridge proportional gain (Kp), then clicking update from core, resets the min on time to zero.
Bug confirmed. Thanks for reporting it.
Setting the beer-to-fridge max difference causes the minimum on time to become zero.
Tested on the Photon, 0.4.3
Related to what is fixed here:
The min cool time is in EEPROM/memory just after the max difference:
https://github.com/BrewPi/firmware/blob/master/app/controller/TempControl.h#L67
This is why it gets overwritten when applying the max difference with the wrong data length.
I could not reproduce it when changing Kp, it seems to only happen with the max difference.
fixed in 0.4.4