BuilderIO/mitosis

SolidJS: mitosis compiles the attribute "for" to "htmlFor"

kauderk opened this issue · 2 comments

kauderk commented

I am interested in helping provide a fix!

Yes

Which generators are impacted?

  • All
  • Angular
  • HTML
  • Preact
  • Qwik
  • React
  • React-Native
  • Solid
  • Stencil
  • Svelte
  • Vue
  • Web components

Reproduction case

https://mitosis.builder.io/?outputTab=M4ewNglgJkA%3D&code=KYDwDg9gTgLgBAE2AMwIYFcA29noHYDGMAlhHnALICeAwhALaR7B4wAUYUEYAzgFxwA3nGIIBPGFGJ4A5nAC%2BASiEAoOHCjAY6KOQA8mVACNgmOMmgBeQQHJDJzDfkA%2BW%2FdNO9AeneZnAbhV5FSA

Expected Behaviour

the "for" attribute shouldn't compile to "htmlFor"

Actual Behaviour

I know it's a small issue but I guess mitosis has to adapt to all the frameworks changes
https://github.com/solidjs/solid/releases/tag/v1.4.0#:~:text=className%2C%20htmlFor%20deprecated

Additional Information

Maybe mitosis should accept version targets

samijaber commented

Just gotta remove this mapping!

mitosis/packages/core/src/generators/solid/blocks.ts

Line 13 in e862056

for: 'htmlFor',