Broken Dockerfile
Closed this issue · 2 comments
alsyia commented
Hello,
Thanks for this amazing tool ! Just wanted to let you know that the Dockerfile does not build on master
.
I think there are two issues:
html
directory has been renamed tofrontend
in 38bf4fe so the Dockerfile should be updated accordingly (line 19):
- COPY html/dist/ /opt/app/html/dist/
+ COPY frontend/dist/ /opt/app/frontend/dist/
- Dependency
instruments
is sourced from Git but the base image doesn't have Git, so something likeRUN apk add git
is needed in the Dockerfile (although my understanding is that this one is temporary?)
It works on my workstation with this two fixes.
Please let me know if I can help (by doing the PR maybe?)!
Thank you 😄
Fitblip commented
Doh! Sorry for the breakage. If you want to submit a PR I’ll happily review
otherwise I’ll have to get to it once things settle down work-wise (likely
this weekend).
Thanks for the heads up!
…On Wed, Feb 19, 2020 at 9:42 AM alsyia ***@***.***> wrote:
Hello,
Thanks for this amazing tool ! Just wanted to let you know that the
Dockerfile does not build on master.
I think there are two issues:
- html directory has been renamed to frontend in 38bf4fe
<38bf4fe>
so the Dockerfile should be updated accordingly (line 19):
- COPY html/dist/ /opt/app/html/dist/
+ COPY frontend/dist/ /opt/app/frontend/dist/
- Dependency instruments is sourced from Git but the base image
doesn't have Git, so something like RUN apk add git is needed in the
Dockerfile (although my understanding is that this one is temporary?)
It works on my workstation with this two fixes.
Please let me know if I can help (by doing the PR maybe?)!
Thank you 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#31?email_source=notifications&email_token=AAIF3VUB6HV3KGL35ELTUULRDVAMPA5CNFSM4KX2XMY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOVFCAQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIF3VS3JGKOTSOQJITR5D3RDVAMPANCNFSM4KX2XMYQ>
.
alsyia commented
No worries! I did the PR, please tell me if there is anything wrong, and thank you for your time! :)