Issue Rendering CardTable.java

Question

Issue Rendering CardTable.java

nic-instruction opened this issue 4 years ago · 6 comments

Hello,

This is my first time teaching from your textbook, and I've enjoyed it a lot, but I'm running into a problem when running CardTable.java in Eclipse. It has no visible errors, but launches in the upper right-hand corner of the screen completely collapsed and doesn't render a deck when it is expanded.

From the Chapter 12 instructions I got the impression it would work out of the box and could then be used to implement a solitaire game. I've attached a picture for reference.

The example graphics code in the appendix runs without issue and I haven't had trouble implementing other assignments as examples. We were hoping to use this code as the basis for a class final project, so if there's a quick fix, let me know.

Thank you!

Answer 1 · 2021-03-10T19:48:57.000Z

I can't seem to reproduce the issue on my end. I tried running it from Eclipse on both my Mac laptop and Linux desktop, and in both cases, it shows the Card Table window correctly. I did notice a difference in the code from what we did in Chapters 15-17. Will you try changing Line 87 to frame.add(canvas); and let me know if that makes a difference on your end?

Answer 2 · 2021-03-10T20:08:13.000Z

Hi Chris, Thank you so much for getting back to me so quickly! I tested with the new line and the behavior did not change, you had already put something similar on line 87 in the version I'm using: Canvas canvas = new CardTable(); //frame.getContentPane().add(canvas); frame.add(canvas); //suggested line So, I tried it with frame.getContentPane().add(canvas); (original), with frame.add(canvas) in addition, and with frame.getContentPane().add(canvas) commented out and frame.add(canvas) on the next line (the paste above is from that). One thing I noticed on my end is that if I change the name of the folder where the pictures are kept, I do not get an error, in fact, the behavior is the same. I added a println statement and checked the names, they appear correct, I also played with adding a ./ before the folder name (I'm on a mac), but got the same result. It may be something completely different, but my thought is that it is not finding the pictures for whatever reason. I don't know if this would be a path issue, or what. I did clone directly from your repository to make sure the file structure was correct, and got the same result. Two of my students were able to reproduce this issue as well. I'm wondering if we're missing something environmental? Thank you!

…

________________________________ From: Chris Mayfield <notifications@github.com> Sent: Wednesday, March 10, 2021 11:49 AM To: ChrisMayfield/ThinkJavaCode2 <ThinkJavaCode2@noreply.github.com> Cc: Bade, Nicole <Nicole.Bade@Seattlecolleges.edu>; Author <author@noreply.github.com> Subject: Re: [ChrisMayfield/ThinkJavaCode2] Issue Rendering CardTable.java (#4) I can't seem to reproduce the issue on my end. I tried running it from Eclipse on both my Mac laptop and Linux desktop, and in both cases, it shows the Card Table window correctly. I did notice a difference in the code from what we did in Chapters 15-17. Will you try changing Line 87 to frame.add(canvas); and let me know if that makes a difference on your end? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChrisMayfield%2FThinkJavaCode2%2Fissues%2F4%23issuecomment-795986765&data=04%7C01%7C%7C692288d9094648e61eaf08d8e3fd944b%7C02d8ff38d7114e31a9156cb5cff788df%7C0%7C0%7C637510025545144105%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qdMljJANSRf4g2JlA5LjsBDS2Ob7XQT%2BUeFexW5zgBw%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFIPVEJHQGKK2OWZVGLY553TC65KRANCNFSM4Y5ICEQA&data=04%7C01%7C%7C692288d9094648e61eaf08d8e3fd944b%7C02d8ff38d7114e31a9156cb5cff788df%7C0%7C0%7C637510025545154098%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aTuV6lTmztsncI6Lz9jvWxHIwEZUYRSFHTNsQvuJsoU%3D&reserved=0>. CAUTION: This email originated outside of the Seattle Colleges’ email system. Do not click links or open attachments unless you recognize the sender and know the content is safe. Questions? Contact IT Services at x6333 (Central), x3630 (North), x5844 (South) or email ITHelp@seattlecolleges.edu.

Answer 3 · 2021-03-10T20:22:43.000Z

You're probably right. I changed the name of the folder and got the same result (no error message and an empty window in the upper left corner). I looked at the source code for ImageIcon, and it indeed ignores FileNotFoundException. As a result, the height and width of each image object are -1. Nice work, Swing. :) I don't know if it would help, but I'm using OpenJDK 11 on both of my machines. It might be a bug in the JDK if you're using a different version.

Answer 4 · 2021-03-10T21:10:20.000Z

I'll try installing OpenJDK 11, and see if that helps. I've tried moving it to a resources folder and changing cardset to resources on line 24, but that was not successful. Hoping OpenJDK 11 will do the trick. I'll let you know! String cardset = "resources";

…

________________________________ From: Chris Mayfield <notifications@github.com> Sent: Wednesday, March 10, 2021 12:22 PM To: ChrisMayfield/ThinkJavaCode2 <ThinkJavaCode2@noreply.github.com> Cc: Bade, Nicole <Nicole.Bade@Seattlecolleges.edu>; Author <author@noreply.github.com> Subject: Re: [ChrisMayfield/ThinkJavaCode2] Issue Rendering CardTable.java (#4) You're probably right. I changed the name of the folder and got the same result (no error message and an empty window in the upper left corner). I looked at the source code for ImageIcon, and it indeed ignores FileNotFoundException. As a result, the height and width of each image object are -1. Nice work, Swing. :) I don't know if it would help, but I'm using OpenJDK 11 on both of my machines. It might be a bug in the JDK if you're using a different version. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FChrisMayfield%2FThinkJavaCode2%2Fissues%2F4%23issuecomment-796039524&data=04%7C01%7C%7C18d35ba9fe0e461b8dde08d8e4024c38%7C02d8ff38d7114e31a9156cb5cff788df%7C0%7C0%7C637510045828155846%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2F6oOFFyoMLNFaUH6iXPLzZKf6zUjTVXGm3Ht4UUbQDA%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFIPVENWO2VYSMLC5DGTWSLTC7BJHANCNFSM4Y5ICEQA&data=04%7C01%7C%7C18d35ba9fe0e461b8dde08d8e4024c38%7C02d8ff38d7114e31a9156cb5cff788df%7C0%7C0%7C637510045828165846%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0uPpEpONNyXvnR3pEI7x6EpHTDRPb5e6y9ThmrMpMVk%3D&reserved=0>. CAUTION: This email originated outside of the Seattle Colleges’ email system. Do not click links or open attachments unless you recognize the sender and know the content is safe. Questions? Contact IT Services at x6333 (Central), x3630 (North), x5844 (South) or email ITHelp@seattlecolleges.edu.

Answer 5 · 2021-03-10T22:19:38.000Z

Unfortunately I got the same result with OpenJDK 11. (Picture attached).
I did realize that I'm on a fairly new version of eclipse:

Version: 2020-09 (4.17.0)
Build id: 20200910-1200

And my students are a version after me, so I went down the class path rabbit hole. For whatever reason it looks like the path only extends into the ch12 folder, and doesn't make it to the cardset-oxymoron folder at all, so I moved the folder out to the same level as the chapter folders, and then went into my project properties > Java Build Path > Source and added cardset-oxymoron to the source path. This appears to have worked!

Even being at the top level, the folder was not detected until I added it to the class path, so I don't know what the simple long-term solution to this problem is, but at least it's working!

Thank you so much for getting back to me so quickly, and for testing everything on your end, I really appreciate it!

Answer 6 · 2021-03-10T22:34:27.000Z

You're welcome. I'll go ahead and close the issue since it's because of Eclipse configuration.