ClandininLab/brainsss

wildcard imports in __init__.py

poldrack opened this issue · 1 comments

wildcard imports (import *) are problematic - e.g. https://rules.sonarsource.com/python/RSPEC-2208

they can be particularly confusing within init.py because they make it challenging to figure out where a particular function is coming from and many people don't think to look there to figure out what's going on.

since I found it, I'm happy to fix it, but it will require breaking changes throughout the code so wanted to first check on what you think about this.

after a bit of thought, removing these imports will probably break too many things, so I'd leave it in place, but try to stop using brainsss.xxx imports (as opposed to e.g. brainsss.utils.xxx)