Acceptance Tests/Linting must pass before merging
wbprice opened this issue · 4 comments
CodeShip should run tests on a branch when a PR is opened so we can catch test failures and linting errors when a PR is opened.
YUSS
On 12 September 2016 15:13:03 GMT-04:00, "W. Blaine Price" notifications@github.com wrote:
CodeShip should run tests on a branch when a PR is opened so we can
catch test failures and linting errors when a PR is opened.You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#186
Ryan Y.
GnuPG Key: 0x358CD775
VoIP (ZRTP-encrypted): ryayak1460@ostel.co
IM (OTR encryption): ryayak1460@protingumas.com
So we need to do this for Docker Cloud to run tests.
https://docs.docker.com/docker-cloud/builds/automated-testing/
OK so Docker Cloud expects a specific compose file that tells it what tests to run and how environment should be setup for that test. I've added one to a feature branch here: https://github.com/Code4HR/okcandidate/blob/186-test-with-dockercloud/docker-compose.test.yml
Docker Cloud will autorun anything *.test.yml as a compose file, and expect a happy exit before it marks it successful.