Time labels shift

Question

Time labels shift

rozetko opened this issue 6 years ago · 25 comments

Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8)
Current behaviour:

Expected behaviour:

@nsayedqt, am I right? Is it the expected behaviour?

Answer 1 · 2018-10-10T18:27:58.000Z

Yes that is correct Regards, Nausheen Sayed Product Owner, QTDashboard

…

________________________________ From: rozetko <notifications@github.com> Sent: Wednesday, October 10, 2018 2:25:22 PM To: CorpGlory/grafana-multibar-graph-panel Cc: Nausheen Sayed; Mention Subject: [CorpGlory/grafana-multibar-graph-panel] Time labels shift (#22) Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8) Current behaviour: [image]<https://user-images.githubusercontent.com/1989898/46752042-e0aeab80-ccc4-11e8-9d73-d22b146bff9a.png> Expected behaviour: [image]<https://user-images.githubusercontent.com/1989898/46752077-f6bc6c00-ccc4-11e8-8cb0-c3141efddcb2.png> @nsayedqt<https://github.com/nsayedqt>, am I right? Is it the expected behaviour? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AV9JvlfJEf0vP6z9hMqkIJ6o940jIyXlks5ujjuSgaJpZM4XWDm8>.

_______________________________________________________________________________________________________________________________________________________________________________________________________ This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this E-mail. Please notify the sender immediately by E-mail if you have received this E-mail by mistake and delete this E-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message or attached documents or for any damage suffered by your computer system caused by any errors or viruses contained in the E-mail message or any attached documents. QualiTest Group may monitor email traffic data.

Answer 2 · 2018-10-10T18:34:04.000Z

Also when I hover over the bars, the dates displayed are wrong. The data is organized or pointing to 10/8, 10/15, 10/22 but both the axes and hovering shows wrong dates. I am using MYSQL data source. From: rozetko <notifications@github.com> Sent: Wednesday, October 10, 2018 2:25 PM To: CorpGlory/grafana-multibar-graph-panel <grafana-multibar-graph-panel@noreply.github.com> Cc: Nausheen Sayed <nsayed@qualitestgroup.com>; Mention <mention@noreply.github.com> Subject: [CorpGlory/grafana-multibar-graph-panel] Time labels shift (#22) Currently, if you have data grouped by week (for example) - you have time along with time labels shifted (there is 10/16 after 10/8, although it should be 10/15 after 10/8) Current behaviour: [image]<https://user-images.githubusercontent.com/1989898/46752042-e0aeab80-ccc4-11e8-9d73-d22b146bff9a.png> Expected behaviour: [image]<https://user-images.githubusercontent.com/1989898/46752077-f6bc6c00-ccc4-11e8-8cb0-c3141efddcb2.png> @nsayedqt<https://github.com/nsayedqt>, am I right? Is it the expected behaviour? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AV9JvlfJEf0vP6z9hMqkIJ6o940jIyXlks5ujjuSgaJpZM4XWDm8>.

…

_______________________________________________________________________________________________________________________________________________________________________________________________________ This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this E-mail. Please notify the sender immediately by E-mail if you have received this E-mail by mistake and delete this E-mail from your system. E-mail transmission cannot be guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or contain viruses. The sender therefore does not accept liability for any errors or omissions in the contents of this message or attached documents or for any damage suffered by your computer system caused by any errors or viruses contained in the E-mail message or any attached documents. QualiTest Group may monitor email traffic data.

Answer 3 · 2018-10-11T15:07:10.000Z

We're implementing it now
Going to generate labels by groups amount (if there are not much of groups - every group would have a label, if there are too many groups - every nth of them would be skipped)
For example:

groups here are big enough - we can put label under each of them
but groups here are too small - we would skip label under every 2nd one

Answer 4 · 2018-10-11T15:29:11.000Z

Assuming the groups will have option for weekly grouping? Will it also resolve the issue with dates upon hovering on the bars (currently it is not showing correct date)?

Answer 5 · 2018-10-11T17:29:50.000Z

Hey, @nsayedqt

Let me make it clear:
Grouping is based on datasource response. Plugin doesn't transform data. It is something datasource should handle.

Suppose you have such dataset:

It is displayed like this:

Also, you can test it here:
http://grafana5.corpglory.com/d/r7Zvhi1ik/multibar
User: guest
Password: tx8yM

I believe you got your data already grouped by MySQL, so that should work in your case.

P.S. Could you please create another issue for tooltips? It would be nice to have more info on it (i.e. tooltip screenshots)

Answer 6 · 2018-10-11T17:36:38.000Z

looks right in your environment, but i need to test in mine. Where can i download the latest code?

Answer 7 · 2018-10-11T17:51:14.000Z

@rozetko ok lets try this again:
This is my query result:

this is my graph - x axes ticks are not pointing to correct dates and when i hover over it shows wrong dates as well

my data is grouped correctly, query is correct but display is wrong
I hope i am able to convey my issue

Answer 8 · 2018-10-11T18:07:04.000Z

I'll make a release in half an hour and let you know
About tooltip: seems like timezone problem. What timezone is set in your dashboard? Seems like UTC

Answer 9 · 2018-10-11T18:13:12.000Z

its default timezone which i guess is UTC

Answer 10 · 2018-10-11T18:31:31.000Z

@nsayedqt you can install new version as you always do:

cd $GRAFANA_PATH/data/plugins/
wget https://github.com/CorpGlory/grafana-multibar-graph-panel/releases/download/0.1.2/grafana-multibar-graph-panel-0.1.2.tar.gz
tar -zxvf grafana-multibar-graph-panel-0.1.2.tar.gz

And restart Grafana after that

Answer 11 · 2018-10-11T18:53:01.000Z

@rozetko thanks will do now

Answer 12 · 2018-10-11T19:16:53.000Z

@rozetko i dont see any change:

infact the date changes when i hover on the bars. See how for 16 Oct, it is showing 15th on one bar, then 16th, then 17th... very confusing.

Answer 13 · 2018-10-11T19:28:29.000Z

Did you restart Grafana server after updating plugin?
Seems like Grafana cached an old plugin version
Can you please try to clear cache? F12 (Chrome Dev Tools would be opened) -> Right click on refresh button -> Empty Cache and Hard Reload

Answer 14 · 2018-10-11T19:33:33.000Z

@rozetko did that, no change

i have another env that i am going to try do a fresh isntall and try

Answer 15 · 2018-10-11T19:44:30.000Z

@rozetko
Tried on a new server, where this plugin was never installed. The x axes is still off though the dates on hovering are correct

Answer 16 · 2018-10-11T19:45:42.000Z

@rozetko due you think the plugin (or the ticks) is responding differently for a MYSQL data source?

Answer 17 · 2018-10-11T19:46:42.000Z

@nsayedqt seems like this is the reason

Answer 18 · 2018-10-11T19:48:36.000Z

I'll try it with MySQL tomorrow and we'll see

Answer 19 · 2018-10-11T19:49:31.000Z

@rozetko you know whats more scary - when i zoom in, or set time to last 30 or 7 days - the axes becomes zero:

I dont see that in ur environment

Answer 20 · 2018-10-11T19:53:57.000Z

About zeroes: did you have the same behaviour with previous plugin versions?

Answer 21 · 2018-10-11T19:56:10.000Z

@rozetko sorry dont remember - i just saw it

Answer 22 · 2018-10-11T20:03:55.000Z

@nsayedqt no problem

Answer 23 · 2018-10-12T15:15:35.000Z

@rozetko any luck reproducing it with MYSQL today?

Answer 24 · 2018-10-12T15:17:36.000Z

@nsayedqt we are working on this right now

Answer 25 · 2018-10-12T18:55:01.000Z

Hey, @nsayedqt! Tested with MySQL and got the same result

Let's wait until you test it with the new 0.1.3 version